Re: Review Request 54280: Made `configure.ac` default to use to brew apr on OS X in mesos.

2016-12-02 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54280/#review157811
---


Ship it!




Maybe document that this brings it on par with the handling of --with-svn in 
terms of looking for the brew installation?


configure.ac (lines 683 - 688)


A comment about the strategy taken here (that we look for brew's 
installation before trying the system-installed one) would be great!


- Benjamin Mahler


On Dec. 2, 2016, 1 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54280/
> ---
> 
> (Updated Dec. 2, 2016, 1 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   configure.ac 5380cbc6a7951ede2f883f7045952a3f3434479e 
> 
> Diff: https://reviews.apache.org/r/54280/diff/
> 
> 
> Testing
> ---
> 
> Built on OS X 10.12.1 with `CC="ccache clang-3.7 
> -Wno-deprecated-declarations" CXX="ccache clang++-3.7 
> -Wno-deprecated-declarations" ../configure --enable-optimize 
> --enable-libevent --enable-ssl --disable-python`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 54280: Made `configure.ac` default to use to brew apr on OS X in mesos.

2016-12-01 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54280/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  configure.ac 5380cbc6a7951ede2f883f7045952a3f3434479e 

Diff: https://reviews.apache.org/r/54280/diff/


Testing
---

Built on OS X 10.12.1 with `CC="ccache clang-3.7 -Wno-deprecated-declarations" 
CXX="ccache clang++-3.7 -Wno-deprecated-declarations" ../configure 
--enable-optimize --enable-libevent --enable-ssl --disable-python`.


Thanks,

Michael Park