Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On Maj 11, 2017, 8:35 rano, Tomasz Janiszewski wrote: > > src/webui/master/static/browse.html > > Lines 17-20 (original), 17-20 (patched) > > > > > > How about usign `` here instead of list? Then `/` will be just

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- (Updated June 20, 2017, 7:58 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- (Updated June 20, 2017, 3:48 a.m.) Review request for . Bugs: MESOS-7468

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On May 11, 2017, 8:35 a.m., Tomasz Janiszewski wrote: > > src/webui/master/static/browse.html > > Lines 17-20 (original), 17-20 (patched) > > > > > > How about usign `` here instead of list? Then `/` will be just

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- (Updated June 20, 2017, 3:41 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On Maj 11, 2017, 8:35 rano, Tomasz Janiszewski wrote: > > src/webui/master/static/browse.html > > Lines 17-20 (original), 17-20 (patched) > > > > > > How about usign `` here instead of list? Then `/` will be just

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review174615 --- src/webui/master/static/browse.html Lines 17-20 (original),

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On May 11, 2017, 12:38 a.m., Benjamin Mahler wrote: > > src/webui/master/static/browse.html > > Lines 17-20 (original), 17-20 (patched) > > > > > > I suspect, if my understanding is correct, you could do the

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On May 11, 2017, 12:38 a.m., Benjamin Mahler wrote: > > Ok, I understand now what's going on in this change. I gave some > > suggestions for comments / naming to clarify this. > > > > It feels like a hack however, since I would expect the breadcrumb '/' > > characters to be getting copied.

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review174590 --- Fix it, then Ship it! Ok, I understand now what's going on in

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review174191 --- Patch looks great! Reviews applied: [58874] Passed command:

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- (Updated May 8, 2017, 8:01 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- (Updated May 8, 2017, 8 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On May 3, 2017, 7:45 p.m., Benjamin Mahler wrote: > > src/webui/master/static/browse.html > > Lines 15-16 (original), 15-16 (patched) > > > > > > Looking at the gif, it seems the slashes weren't copied before? Do

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review173801 --- src/webui/master/static/browse.html Lines 15-16 (original),

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review173796 --- Patch looks great! Reviews applied: [58874] Passed command:

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On Maj 1, 2017, 8:14 po południu, Tomasz Janiszewski wrote: > > src/webui/master/static/browse.html > > Line 17 (original), 17 (patched) > > > > > > Could you keep original formatting? > > haosdent huang wrote: >

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On May 1, 2017, 10:49 p.m., Benjamin Mahler wrote: > > I'm a bit lost, is there a visual change here? If so, can you include the > > screenshots? > > > > Could you spell out the problem? Is it that when trying to copy a path in > > the file browser, it includes unwanted spaces? Oh, yes, it

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- (Updated May 3, 2017, 4:29 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- (Updated May 3, 2017, 4:25 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On May 1, 2017, 8:14 p.m., Tomasz Janiszewski wrote: > > src/webui/master/static/browse.html > > Line 17 (original), 17 (patched) > > > > > > Could you keep original formatting? Change to ``` {{dir}}/ ``` Is

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review173526 --- I'm a bit lost, is there a visual change here? If so, can you

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review173499 --- Fix it, then Ship it! Nice usability improvement.

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review173451 --- Patch looks great! Reviews applied: [58874] Passed command:

Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- Review request for mesos, Benjamin Mahler and Tomasz Janiszewski. Repository: