Re: Review Request 61511: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61511/#review182768 --- Ship it! Ship It! - Greg Mann On Aug. 10, 2017, 9:10 p.m., G

Re: Review Request 61511: Improved the readability of some assertions/expectations.

> On Aug. 9, 2017, 3:21 p.m., Benjamin Bannier wrote: > > src/tests/api_tests.cpp > > Line 1 (original), 1 (patched) > > > > > > Searching with > > > > $ git grep -E '(EXPECT|ASSERT)_(EQ|NE).*(0u,\s.*size(

Re: Review Request 61511: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61511/ --- (Updated Aug. 10, 2017, 9:10 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 61511: Improved the readability of some assertions/expectations.

> On Aug. 9, 2017, 5:21 p.m., Benjamin Bannier wrote: > > Thanks for the cleanup Gaston! > > > > Until looking at your patch I didn't realize how widespread the mistake of > > possibly using junk elements from possibly empty containers was, e.g., > > > > EXPECT_NE(0u, offers.size()); // o

Re: Review Request 61511: Improved the readability of some assertions/expectations.

> On Aug. 9, 2017, 5:21 p.m., Benjamin Bannier wrote: > > src/tests/api_tests.cpp > > Line 1 (original), 1 (patched) > > > > > > Searching with > > > > $ git grep -E '(EXPECT|ASSERT)_(EQ|NE).*(0u,\s.*size(

Re: Review Request 61511: Improved the readability of some assertions/expectations.

> On Aug. 9, 2017, 3:21 p.m., Benjamin Bannier wrote: > > src/tests/api_tests.cpp > > Line 1 (original), 1 (patched) > > > > > > Searching with > > > > $ git grep -E '(EXPECT|ASSERT)_(EQ|NE).*(0u,\s.*size(

Re: Review Request 61511: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61511/#review182488 --- Fix it, then Ship it! Thanks for the cleanup Gaston! Until loo

Re: Review Request 61511: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61511/ --- (Updated Aug. 9, 2017, 1:01 a.m.) Review request for mesos, Benjamin Bannier, J

Review Request 61511: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61511/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone. Repository: