Re: Review Request 61524: Moved task validation from `getExecutorInfo` to `runTask` on agent.

2017-08-09 Thread Greg Mann
> On Aug. 9, 2017, 6:04 p.m., Benjamin Mahler wrote: > > src/slave/slave.cpp > > Lines 4987-4989 (original), 4987-4989 (patched) > > > > > > Perhaps a note here saying that the master injects the executor for > >

Re: Review Request 61524: Moved task validation from `getExecutorInfo` to `runTask` on agent.

2017-08-09 Thread Greg Mann
> On Aug. 9, 2017, 6:04 p.m., Benjamin Mahler wrote: > > src/slave/slave.cpp > > Lines 4987-4989 (original), 4987-4989 (patched) > > > > > > Perhaps a note here saying that the master injects the executor for > >

Re: Review Request 61524: Moved task validation from `getExecutorInfo` to `runTask` on agent.

2017-08-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61524/#review182510 --- Ship it! Ship It! - Greg Mann On Aug. 9, 2017, 1:14 p.m.,

Re: Review Request 61524: Moved task validation from `getExecutorInfo` to `runTask` on agent.

2017-08-09 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61524/#review182502 --- Ship it! Can we also add a test that ensures that getting the

Review Request 61524: Moved task validation from `getExecutorInfo` to `runTask` on agent.

2017-08-09 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61524/ --- Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone. Bugs: