Re: Review Request 61535: Updated comments for the agent's 'getExecutorInfo()' helper function.

2017-08-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61535/#review182539
---



Discarding because I included these changes when committing the following 
patch: https://reviews.apache.org/r/61524/

- Greg Mann


On Aug. 9, 2017, 6:58 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61535/
> ---
> 
> (Updated Aug. 9, 2017, 6:58 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7871
> https://issues.apache.org/jira/browse/MESOS-7871
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates comments associated with the getExecutorInfo()
> helper function to more accurately reflect the fact that TaskInfo
> objects launched as part of a task group will have both ExecutorInfo
> and CommandInfo set.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79 
>   src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b 
> 
> 
> Diff: https://reviews.apache.org/r/61535/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 61535: Updated comments for the agent's 'getExecutorInfo()' helper function.

2017-08-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61535/
---

(Updated Aug. 9, 2017, 6:58 p.m.)


Review request for mesos, Andrei Budnik and Benjamin Mahler.


Bugs: MESOS-7871
https://issues.apache.org/jira/browse/MESOS-7871


Repository: mesos


Description (updated)
---

This patch updates comments associated with the getExecutorInfo()
helper function to more accurately reflect the fact that TaskInfo
objects launched as part of a task group will have both ExecutorInfo
and CommandInfo set.


Diffs
-

  src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79 
  src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b 


Diff: https://reviews.apache.org/r/61535/diff/2/


Testing
---


Thanks,

Greg Mann

Re: Review Request 61535: Updated comments for the agent's 'getExecutorInfo()' helper function.

2017-08-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61535/
---

(Updated Aug. 9, 2017, 6:57 p.m.)


Review request for mesos, Andrei Budnik and Benjamin Mahler.


Bugs: MESOS-7871
https://issues.apache.org/jira/browse/MESOS-7871


Repository: mesos


Description (updated)
---

Updated comments for the agent's 'getExecutorInfo()' helper function.


Diffs (updated)
-

  src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79 
  src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b 


Diff: https://reviews.apache.org/r/61535/diff/2/

Changes: https://reviews.apache.org/r/61535/diff/1-2/


Testing
---


Thanks,

Greg Mann

Re: Review Request 61535: Updated comments for the agent's 'getExecutorInfo()' helper function.

2017-08-09 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61535/#review182513
---


Ship it!





src/slave/slave.hpp
Lines 399-400 (original), 399-401 (patched)


then we generate an ExecutorInfo corresponding to the command executor

suitable for command executor sounds a bit odd?


- Benjamin Mahler


On Aug. 9, 2017, 6:33 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61535/
> ---
> 
> (Updated Aug. 9, 2017, 6:33 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7871
> https://issues.apache.org/jira/browse/MESOS-7871
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates comments associated with the `getExecutorInfo()`
> helper function to more accurately reflect the fact that `TaskInfo`
> objects launched as part of a task group will have both `ExecutorInfo`
> and `CommandInfo` set.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79 
>   src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b 
> 
> 
> Diff: https://reviews.apache.org/r/61535/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 61535: Updated comments for the agent's 'getExecutorInfo()' helper function.

2017-08-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61535/
---

Review request for mesos, Andrei Budnik and Benjamin Mahler.


Bugs: MESOS-7871
https://issues.apache.org/jira/browse/MESOS-7871


Repository: mesos


Description
---

This patch updates comments associated with the `getExecutorInfo()`
helper function to more accurately reflect the fact that `TaskInfo`
objects launched as part of a task group will have both `ExecutorInfo`
and `CommandInfo` set.


Diffs
-

  src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79 
  src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b 


Diff: https://reviews.apache.org/r/61535/diff/1/


Testing
---


Thanks,

Greg Mann