Re: Review Request 61558: Move duplicate comment closer to implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61558/ --- (Updated Sept. 7, 2017, 12:06 p.m.) Review request for mesos and Alexander Rukletsov. Repository: mesos Description --- Move duplicate comment closer to implementation. Diffs (updated) - include/mesos/mesos.proto 1c74cbb3e8c97145975c13e1e42cbffd1e84c827 include/mesos/v1/mesos.proto 9aef05f34be5d187eb4ec20133af6f1d1030ad44 src/master/master.cpp 14d94cfa0e96881f77dd6e0c3449fdc0613e36ce Diff: https://reviews.apache.org/r/61558/diff/2/ Changes: https://reviews.apache.org/r/61558/diff/1-2/ Testing --- Thanks, Benno Evers
Re: Review Request 61558: Move duplicate comment closer to implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61558/#review183177 --- Bad patch! Reviews applied: [61495, 61558] Logs available here: http://104.210.40.105/logs/master/61558 - Mesos Reviewbot Windows On Aug. 10, 2017, 7:01 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61558/ > --- > > (Updated Aug. 10, 2017, 7:01 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > --- > > Move duplicate comment closer to implementation. > > > Diffs > - > > include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461 > include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa > src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 > > > Diff: https://reviews.apache.org/r/61558/diff/1/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 61558: Move duplicate comment closer to implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61558/#review183176 --- Patch looks great! Reviews applied: [61495, 61558] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On Aug. 10, 2017, 2:01 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61558/ > --- > > (Updated Aug. 10, 2017, 2:01 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > --- > > Move duplicate comment closer to implementation. > > > Diffs > - > > include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461 > include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa > src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 > > > Diff: https://reviews.apache.org/r/61558/diff/1/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 61558: Move duplicate comment closer to implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61558/#review183157 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 10, 2017, 2:01 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61558/ > --- > > (Updated Aug. 10, 2017, 2:01 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > --- > > Move duplicate comment closer to implementation. > > > Diffs > - > > include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461 > include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa > src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 > > > Diff: https://reviews.apache.org/r/61558/diff/1/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Review Request 61558: Move duplicate comment closer to implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61558/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Description --- Move duplicate comment closer to implementation. Diffs (updated) - include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461 include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 Diff: https://reviews.apache.org/r/61558/diff/1/ Testing --- Thanks, Benno Evers
