Re: Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65637/#review197426 --- Ship it! Ship It! - Greg Mann On Feb. 13, 2018, 3:52 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65637/ > --- > > (Updated Feb. 13, 2018, 3:52 p.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-8577 > https://issues.apache.org/jira/browse/MESOS-8577 > > > Repository: mesos > > > Description > --- > > Previously, if `attachContainerOutput()` returned http error for > `LAUNCH_NESTED_CONTAINER_SESSION` call, we didn't destroy the nested > container. From the point of view of API user, if > `LAUNCH_NESTED_CONTAINER_SESSION` returns an error, then no nested > container should be in `RUNNING` state. This patch fixes the API > issue by destroying a nested container on http errors and failures > of `attachContainerOutput()`. > > > Diffs > - > > src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a > > > Diff: https://reviews.apache.org/r/65637/diff/1/ > > > Testing > --- > > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65637/#review197421 --- Ship it! Ship It! - Gaston Kleiman On Feb. 13, 2018, 7:52 a.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65637/ > --- > > (Updated Feb. 13, 2018, 7:52 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-8577 > https://issues.apache.org/jira/browse/MESOS-8577 > > > Repository: mesos > > > Description > --- > > Previously, if `attachContainerOutput()` returned http error for > `LAUNCH_NESTED_CONTAINER_SESSION` call, we didn't destroy the nested > container. From the point of view of API user, if > `LAUNCH_NESTED_CONTAINER_SESSION` returns an error, then no nested > container should be in `RUNNING` state. This patch fixes the API > issue by destroying a nested container on http errors and failures > of `attachContainerOutput()`. > > > Diffs > - > > src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a > > > Diff: https://reviews.apache.org/r/65637/diff/1/ > > > Testing > --- > > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65637/#review197419 --- Ship it! Ship It! - Gilbert Song On Feb. 13, 2018, 7:52 a.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65637/ > --- > > (Updated Feb. 13, 2018, 7:52 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-8577 > https://issues.apache.org/jira/browse/MESOS-8577 > > > Repository: mesos > > > Description > --- > > Previously, if `attachContainerOutput()` returned http error for > `LAUNCH_NESTED_CONTAINER_SESSION` call, we didn't destroy the nested > container. From the point of view of API user, if > `LAUNCH_NESTED_CONTAINER_SESSION` returns an error, then no nested > container should be in `RUNNING` state. This patch fixes the API > issue by destroying a nested container on http errors and failures > of `attachContainerOutput()`. > > > Diffs > - > > src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a > > > Diff: https://reviews.apache.org/r/65637/diff/1/ > > > Testing > --- > > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65637/#review197414 --- PASS: Mesos patch 65637 was successfully built and tested. Reviews applied: `['65637']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65637 - Mesos Reviewbot Windows On Feb. 13, 2018, 7:52 a.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65637/ > --- > > (Updated Feb. 13, 2018, 7:52 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-8577 > https://issues.apache.org/jira/browse/MESOS-8577 > > > Repository: mesos > > > Description > --- > > Previously, if `attachContainerOutput()` returned http error for > `LAUNCH_NESTED_CONTAINER_SESSION` call, we didn't destroy the nested > container. From the point of view of API user, if > `LAUNCH_NESTED_CONTAINER_SESSION` returns an error, then no nested > container should be in `RUNNING` state. This patch fixes the API > issue by destroying a nested container on http errors and failures > of `attachContainerOutput()`. > > > Diffs > - > > src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a > > > Diff: https://reviews.apache.org/r/65637/diff/1/ > > > Testing > --- > > internal CI > > > Thanks, > > Andrei Budnik > >
Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65637/ --- Review request for mesos, Gaston Kleiman, Greg Mann, and Vinod Kone. Bugs: MESOS-8577 https://issues.apache.org/jira/browse/MESOS-8577 Repository: mesos Description --- Previously, if `attachContainerOutput()` returned http error for `LAUNCH_NESTED_CONTAINER_SESSION` call, we didn't destroy the nested container. From the point of view of API user, if `LAUNCH_NESTED_CONTAINER_SESSION` returns an error, then no nested container should be in `RUNNING` state. This patch fixes the API issue by destroying a nested container on http errors and failures of `attachContainerOutput()`. Diffs - src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a Diff: https://reviews.apache.org/r/65637/diff/1/ Testing --- internal CI Thanks, Andrei Budnik
