Re: Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- (Updated Feb. 23, 2018, 11:24 p.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/#review198225 --- Ship it! Ship It! - Gilbert Song On Feb. 23, 2018, 2:39 p.m.

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- (Updated Feb. 23, 2018, 10:39 p.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-23 Thread Greg Mann
> On Feb. 23, 2018, 6:06 p.m., Gilbert Song wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 5148 (patched) > > > > > > Should we use `double`? The `sleep` command only accepts integer ar

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-23 Thread Gilbert Song
> On Feb. 23, 2018, 8:35 a.m., Andrei Budnik wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 5133 (patched) > > > > > > `os::write()` is not atomical, so we should write to a temporary fi

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/#review198194 --- Ship it! Ship It! - Gilbert Song On Feb. 22, 2018, 3:28 p.m.

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/#review198192 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines 5148

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-23 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/#review198184 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines 5133

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- (Updated Feb. 22, 2018, 11:28 p.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- (Updated Feb. 22, 2018, 10:56 p.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- (Updated Feb. 22, 2018, 10:55 p.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- (Updated Feb. 22, 2018, 10:46 p.m.) Review request for mesos, Andrei Budnik, Gi

Review Request 65751: Added test fixture for a hung Docker daemon.

2018-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. Bugs: