Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198438 --- Ship it! Ship It! - Gilbert Song On Feb. 28, 2018, 10:05

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198414 --- Ship it! Ship It! - Greg Mann On Feb. 28, 2018, 6:05 p.m.,

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/ --- (Updated Feb. 28, 2018, 6:05 p.m.) Review request for mesos, Alexander

Re: Review Request 65759: Added inspect retries to the Docker executor.

> On Feb. 28, 2018, 10:04 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 242-247 (patched) > > > > > > Doesn't this render the `onFailed` callback registered on L357 useless? > > i.e., the `inspect`

Re: Review Request 65759: Added inspect retries to the Docker executor.

> On Feb. 28, 2018, 10:04 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 242-247 (patched) > > > > > > Doesn't this render the `onFailed` callback registered on L357 useless? > > i.e., the `inspect`

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198382 --- src/docker/executor.cpp Lines 242-247 (patched)

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198328 --- PASS: Mesos patch 65759 was successfully built and tested.

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198176 --- Bad patch! Reviews applied: [65759, 65713, 65743, 65683] Failed

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198175 --- FAIL: Failed to apply the dependent review: 65683. Failed

Re: Review Request 65759: Added inspect retries to the Docker executor.

> On Feb. 23, 2018, 8:57 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 25 (patched) > > > > > > Is this necessary? Without this header, I'm getting: ``` ../../src/docker/executor.cpp:230:32: error:

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198168 --- src/docker/executor.cpp Lines 25 (patched)

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198145 --- Patch looks great! Reviews applied: [65713, 65759] Passed

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198139 --- PASS: Mesos patch 65759 was successfully built and tested.

Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and