Re: Review Request 65886: Do not realpath executables from launcher_dir.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65886/ --- (Updated March 13, 2018, 6:33 a.m.) Review request for mesos. Bugs: MESOS-8667 https://issues.apache.org/jira/browse/MESOS-8667 Repository: mesos Description --- Mesos realpaths some helper executables (e.g., mesos-executor) but not others (mesos-executor and mesos-fetcher) before executing them. I don't see any reason for the inconsistency here, and not doing it saves some code. Diffs - src/slave/containerizer/fetcher.cpp a49411b7bac2d5a50a75d0b802842c2f61fe58c6 src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70 Diff: https://reviews.apache.org/r/65886/diff/1/ Testing --- `make check` passes. Thanks, Benjamin Peterson
Re: Review Request 65886: Do not realpath executables from launcher_dir.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65886/#review198542 --- Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos Reviewbot On March 2, 2018, 9:03 a.m., Benjamin Peterson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65886/ > --- > > (Updated March 2, 2018, 9:03 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > --- > > Mesos realpaths some helper executables (e.g., mesos-executor) but not > others (mesos-executor and mesos-fetcher) before executing them. I > don't see any reason for the inconsistency here, and not doing it > saves some code. > > > Diffs > - > > src/slave/containerizer/fetcher.cpp > a49411b7bac2d5a50a75d0b802842c2f61fe58c6 > src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70 > > > Diff: https://reviews.apache.org/r/65886/diff/1/ > > > Testing > --- > > `make check` passes. > > > Thanks, > > Benjamin Peterson > >
Re: Review Request 65886: Do not realpath executables from launcher_dir.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65886/#review198537 --- PASS: Mesos patch 65886 was successfully built and tested. Reviews applied: `['65886']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65886 - Mesos Reviewbot Windows On March 2, 2018, 9:03 a.m., Benjamin Peterson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65886/ > --- > > (Updated March 2, 2018, 9:03 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > --- > > Mesos realpaths some helper executables (e.g., mesos-executor) but not > others (mesos-executor and mesos-fetcher) before executing them. I > don't see any reason for the inconsistency here, and not doing it > saves some code. > > > Diffs > - > > src/slave/containerizer/fetcher.cpp > a49411b7bac2d5a50a75d0b802842c2f61fe58c6 > src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70 > > > Diff: https://reviews.apache.org/r/65886/diff/1/ > > > Testing > --- > > `make check` passes. > > > Thanks, > > Benjamin Peterson > >
Review Request 65886: Do not realpath executables from launcher_dir.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65886/ --- Review request for mesos. Repository: mesos Description --- Mesos realpaths some helper executables (e.g., mesos-executor) but not others (mesos-executor and mesos-fetcher) before executing them. I don't see any reason for the inconsistency here, and not doing it saves some code. Diffs - src/slave/containerizer/fetcher.cpp a49411b7bac2d5a50a75d0b802842c2f61fe58c6 src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70 Diff: https://reviews.apache.org/r/65886/diff/1/ Testing --- `make check` passes. Thanks, Benjamin Peterson
