Re: Review Request 65932: Added a generic mechanism to check for isolator requirements.

2018-03-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65932/#review198824 --- See my comment around the CNI isolator. Need more discussion on th

Re: Review Request 65932: Added a generic mechanism to check for isolator requirements.

2018-03-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65932/#review198738 --- Patch looks great! Reviews applied: [65932] Passed command: expo

Re: Review Request 65932: Added a generic mechanism to check for isolator requirements.

2018-03-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65932/#review198725 --- PASS: Mesos patch 65932 was successfully built and tested. Review

Re: Review Request 65932: Added a generic mechanism to check for isolator requirements.

2018-03-06 Thread James Peach
> On March 6, 2018, 6:34 p.m., Benjamin Bannier wrote: > > I left two open questions: > > > > * do we want to continue using `root` as the giant bag of priviledges or > > can we be more fine-grained in the future. > > * can we build tooling so isolators do not just declare the widest possible

Re: Review Request 65932: Added a generic mechanism to check for isolator requirements.

2018-03-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65932/#review198716 --- I left two open questions: * do we want to continue using `root`

Review Request 65932: Added a generic mechanism to check for isolator requirements.

2018-03-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65932/ --- Review request for mesos, Andrew Schwartzmeyer and Jie Yu. Bugs: MESOS-6555