Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198977
---



Patch looks great!

Reviews applied: [65936]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 8, 2018, 11:21 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 8, 2018, 11:21 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> b84f1ae17246d94947538efeaf504a2cd247f20e 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/3/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198949
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On March 8, 2018, 3:21 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 8, 2018, 3:21 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> b84f1ae17246d94947538efeaf504a2cd247f20e 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/3/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198921
---



PASS: Mesos patch 65936 was successfully built and tested.

Reviews applied: `['65936']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65936

- Mesos Reviewbot Windows


On March 8, 2018, 11:21 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 8, 2018, 11:21 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> b84f1ae17246d94947538efeaf504a2cd247f20e 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/3/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198915
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On March 8, 2018, 3:21 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 8, 2018, 3:21 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> b84f1ae17246d94947538efeaf504a2cd247f20e 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/3/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/
---

(Updated March 8, 2018, 11:21 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, and 
Joseph Wu.


Changes
---

Addressed comments


Bugs: MESOS-8646
https://issues.apache.org/jira/browse/MESOS-8646


Repository: mesos


Description
---

Changed flags to CreateFile to support Windows symlink path resolution.


Diffs (updated)
-

  3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
  3rdparty/stout/tests/os/filesystem_tests.cpp 
b84f1ae17246d94947538efeaf504a2cd247f20e 


Diff: https://reviews.apache.org/r/65936/diff/3/

Changes: https://reviews.apache.org/r/65936/diff/2-3/


Testing
---

I encountered a permissions error stating "The process cannot access the file 
because it is being used by another process." when attempting to download 
stderr/stdout from a task running on a Windows agent, or when attempting to 
download the mesos agent log on a Windows agent. 

After some very helpful information from Andy and Akash, I made this change and 
confirmed it fixed this issue with the task/agent logs.

I also ran the automated tests on Windows and all tests pass.

I did not test this on Linux, but because this file is compiled only on 
Windows, it shouldn't be necessary.


Thanks,

John Kordich

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198902
---




3rdparty/stout/tests/os/filesystem_tests.cpp
Lines 269 (patched)


I know other tests do this too, but we should default to using 
`sandbox.get()` here for temporary directories (instead of `os::getcwd()`).



3rdparty/stout/tests/os/filesystem_tests.cpp
Lines 273-281 (patched)


The alternative here is to use `os::open` to get a writable `int_fd` (both 
HANDLE and CRT)... but that adds a dependency to the test. I'm fine with this I 
think.

However, you do want to wrap this instead with `SharedHandle`, so we don't 
have to close it at the end:

```
const SharedHandle handle(::CreateFileW(...));
```



3rdparty/stout/tests/os/filesystem_tests.cpp
Lines 284-289 (patched)


Again, we could use `os::write` if we wanted to add it as a dependency of 
the test, so I'm okay with `::WriteFile`.



3rdparty/stout/tests/os/filesystem_tests.cpp
Lines 290 (patched)


Nit picky: `ASSERT_EQ(written, TRUE)`.


- Andrew Schwartzmeyer


On March 8, 2018, 11:22 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 8, 2018, 11:22 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> b84f1ae17246d94947538efeaf504a2cd247f20e 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/2/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198907
---



PASS: Mesos patch 65936 was successfully built and tested.

Reviews applied: `['65936']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65936

- Mesos Reviewbot Windows


On March 8, 2018, 7:22 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 8, 2018, 7:22 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> b84f1ae17246d94947538efeaf504a2cd247f20e 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/2/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Jeff Coffler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198904
---


Ship it!




Ship It!

- Jeff Coffler


On March 8, 2018, 7:22 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 8, 2018, 7:22 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> b84f1ae17246d94947538efeaf504a2cd247f20e 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/2/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/
---

(Updated March 8, 2018, 7:22 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, and 
Joseph Wu.


Changes
---

Addressed comments and added regression test


Bugs: MESOS-8646
https://issues.apache.org/jira/browse/MESOS-8646


Repository: mesos


Description
---

Changed flags to CreateFile to support Windows symlink path resolution.


Diffs (updated)
-

  3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
  3rdparty/stout/tests/os/filesystem_tests.cpp 
b84f1ae17246d94947538efeaf504a2cd247f20e 


Diff: https://reviews.apache.org/r/65936/diff/2/

Changes: https://reviews.apache.org/r/65936/diff/1-2/


Testing
---

I encountered a permissions error stating "The process cannot access the file 
because it is being used by another process." when attempting to download 
stderr/stdout from a task running on a Windows agent, or when attempting to 
download the mesos agent log on a Windows agent. 

After some very helpful information from Andy and Akash, I made this change and 
confirmed it fixed this issue with the task/agent logs.

I also ran the automated tests on Windows and all tests pass.

I did not test this on Linux, but because this file is compiled only on 
Windows, it shouldn't be necessary.


Thanks,

John Kordich

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198844
---




3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
Lines 192-199 (original), 192-199 (patched)


Adding here just so we remember:

Let's add a regression test around `os::realpath` where we open a writable 
handle to file, and then call `os::realpath`.


- Andrew Schwartzmeyer


On March 7, 2018, 10:24 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 7, 2018, 10:24 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/1/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198829
---



Patch looks great!

Reviews applied: [65936]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 7, 2018, 6:24 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 7, 2018, 6:24 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/1/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198810
---



PASS: Mesos patch 65936 was successfully built and tested.

Reviews applied: `['65936']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65936

- Mesos Reviewbot Windows


On March 7, 2018, 6:24 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 7, 2018, 6:24 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/1/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198806
---




3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
Lines 182-184 (original), 182-184 (patched)


This comment needs to be updated.



3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
Line 194 (original), 194 (patched)


Actually, since other changes should be made, can you add the comment?


- Andrew Schwartzmeyer


On March 7, 2018, 10:24 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 7, 2018, 10:24 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/1/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198804
---




3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
Lines 190-200 (original), 190-200 (patched)


What about `get_handle_no_follow`?


- Andrew Schwartzmeyer


On March 7, 2018, 10:24 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 7, 2018, 10:24 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/1/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198801
---


Fix it, then Ship it!





3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
Line 194 (original), 194 (patched)


I'll add a comment detailing why we open with these sharing permissions 
when I commit.


- Andrew Schwartzmeyer


On March 7, 2018, 10:24 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65936/
> ---
> 
> (Updated March 7, 2018, 10:24 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-8646
> https://issues.apache.org/jira/browse/MESOS-8646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed flags to CreateFile to support Windows symlink path resolution.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 
> 
> 
> Diff: https://reviews.apache.org/r/65936/diff/1/
> 
> 
> Testing
> ---
> 
> I encountered a permissions error stating "The process cannot access the file 
> because it is being used by another process." when attempting to download 
> stderr/stdout from a task running on a Windows agent, or when attempting to 
> download the mesos agent log on a Windows agent. 
> 
> After some very helpful information from Andy and Akash, I made this change 
> and confirmed it fixed this issue with the task/agent logs.
> 
> I also ran the automated tests on Windows and all tests pass.
> 
> I did not test this on Linux, but because this file is compiled only on 
> Windows, it shouldn't be necessary.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/
---

(Updated March 7, 2018, 10:24 a.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Jeff Coffler.


Changes
---

Added bug.


Bugs: MESOS-8646
https://issues.apache.org/jira/browse/MESOS-8646


Repository: mesos


Description
---

Changed flags to CreateFile to support Windows symlink path resolution.


Diffs
-

  3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 


Diff: https://reviews.apache.org/r/65936/diff/1/


Testing
---

I encountered a permissions error stating "The process cannot access the file 
because it is being used by another process." when attempting to download 
stderr/stdout from a task running on a Windows agent, or when attempting to 
download the mesos agent log on a Windows agent. 

After some very helpful information from Andy and Akash, I made this change and 
confirmed it fixed this issue with the task/agent logs.

I also ran the automated tests on Windows and all tests pass.

I did not test this on Linux, but because this file is compiled only on 
Windows, it shouldn't be necessary.


Thanks,

John Kordich

Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/
---

Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Jeff Coffler.


Repository: mesos


Description
---

Changed flags to CreateFile to support Windows symlink path resolution.


Diffs
-

  3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
858b3c7c27e95b9cf46a7457c1aaa05a0e19188d 


Diff: https://reviews.apache.org/r/65936/diff/1/


Testing
---

I encountered a permissions error stating "The process cannot access the file 
because it is being used by another process." when attempting to download 
stderr/stdout from a task running on a Windows agent, or when attempting to 
download the mesos agent log on a Windows agent. 

After some very helpful information from Andy and Akash, I made this change and 
confirmed it fixed this issue with the task/agent logs.

I also ran the automated tests on Windows and all tests pass.

I did not test this on Linux, but because this file is compiled only on 
Windows, it shouldn't be necessary.


Thanks,

John Kordich