Re: Review Request 66030: Fixed perf stat output parsing.

2018-03-13 Thread James Peach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66030/#review199127
---


Ship it!




Ship It!

- James Peach


On March 13, 2018, 12:03 a.m., Ilya Pronin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66030/
> ---
> 
> (Updated March 13, 2018, 12:03 a.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-8664
> https://issues.apache.org/jira/browse/MESOS-8664
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a workaround for a bug in 'perf stat'
> (https://lkml.org/lkml/2018/3/6/22) and fixes handling of nameless
> counters.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp b301e25d5cac6488c57e4f983e4867c72368a040 
>   src/tests/containerizer/perf_tests.cpp 
> 7176240bd9caff1efc8b213fe7ae7faae59c0e3e 
> 
> 
> Diff: https://reviews.apache.org/r/66030/diff/1/
> 
> 
> Testing
> ---
> 
> Added new test cases. Ran `sudo make check`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>



Re: Review Request 66030: Fixed perf stat output parsing.

2018-03-12 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66030/#review199055
---



Patch looks great!

Reviews applied: [66030]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 12, 2018, 5:03 p.m., Ilya Pronin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66030/
> ---
> 
> (Updated March 12, 2018, 5:03 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-8664
> https://issues.apache.org/jira/browse/MESOS-8664
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a workaround for a bug in 'perf stat'
> (https://lkml.org/lkml/2018/3/6/22) and fixes handling of nameless
> counters.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp b301e25d5cac6488c57e4f983e4867c72368a040 
>   src/tests/containerizer/perf_tests.cpp 
> 7176240bd9caff1efc8b213fe7ae7faae59c0e3e 
> 
> 
> Diff: https://reviews.apache.org/r/66030/diff/1/
> 
> 
> Testing
> ---
> 
> Added new test cases. Ran `sudo make check`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>



Re: Review Request 66030: Fixed perf stat output parsing.

2018-03-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66030/#review199050
---



PASS: Mesos patch 66030 was successfully built and tested.

Reviews applied: `['66030']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66030

- Mesos Reviewbot Windows


On March 13, 2018, 12:03 a.m., Ilya Pronin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66030/
> ---
> 
> (Updated March 13, 2018, 12:03 a.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-8664
> https://issues.apache.org/jira/browse/MESOS-8664
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a workaround for a bug in 'perf stat'
> (https://lkml.org/lkml/2018/3/6/22) and fixes handling of nameless
> counters.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp b301e25d5cac6488c57e4f983e4867c72368a040 
>   src/tests/containerizer/perf_tests.cpp 
> 7176240bd9caff1efc8b213fe7ae7faae59c0e3e 
> 
> 
> Diff: https://reviews.apache.org/r/66030/diff/1/
> 
> 
> Testing
> ---
> 
> Added new test cases. Ran `sudo make check`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>



Review Request 66030: Fixed perf stat output parsing.

2018-03-12 Thread Ilya Pronin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66030/
---

Review request for mesos and James Peach.


Bugs: MESOS-8664
https://issues.apache.org/jira/browse/MESOS-8664


Repository: mesos


Description
---

This change adds a workaround for a bug in 'perf stat'
(https://lkml.org/lkml/2018/3/6/22) and fixes handling of nameless
counters.


Diffs
-

  src/linux/perf.cpp b301e25d5cac6488c57e4f983e4867c72368a040 
  src/tests/containerizer/perf_tests.cpp 
7176240bd9caff1efc8b213fe7ae7faae59c0e3e 


Diff: https://reviews.apache.org/r/66030/diff/1/


Testing
---

Added new test cases. Ran `sudo make check`.


Thanks,

Ilya Pronin