Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review202147 --- Fix it, then Ship it!

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated April 27, 2018, 12:23 p.m.) Review request for mesos, Chun-Hung

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated April 20, 2018, 11:38 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review201577 --- Ship it! Ship It! - Greg Mann On April 19, 2018, 4:28 p.m.,

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated April 19, 2018, 9:28 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On April 12, 2018, 5:27 p.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 1975 (patched) > > > > > > Hmm I wonder if we should just use a `double` here? Does the > > `Value.Scalar` type provide some

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On April 13, 2018, 12:27 a.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 1975 (patched) > > > > > > Hmm I wonder if we should just use a `double` here? Does the > > `Value.Scalar` type provide

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On April 13, 2018, 12:27 a.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 1975 (patched) > > > > > > Hmm I wonder if we should just use a `double` here? Does the > > `Value.Scalar` type provide

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On April 12, 2018, 5:27 p.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 1975 (patched) > > > > > > Hmm I wonder if we should just use a `double` here? Does the > > `Value.Scalar` type provide some

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated April 13, 2018, 10:20 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated April 13, 2018, 10:15 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On April 13, 2018, 12:27 a.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 1975 (patched) > > > > > > Hmm I wonder if we should just use a `double` here? Does the > > `Value.Scalar` type provide

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On April 13, 2018, 12:27 a.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 1975 (patched) > > > > > > Hmm I wonder if we should just use a `double` here? Does the > > `Value.Scalar` type provide

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review201074 --- include/mesos/mesos.proto Lines 2008 (patched)

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review201067 --- include/mesos/mesos.proto Lines 1975 (patched)

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On March 29, 2018, 5:07 a.m., Benjamin Bannier wrote: > > include/mesos/mesos.proto > > Lines 1920-1921 (patched) > > > > > > These enum values are not handled in a number of switch statements in > > the code so

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On March 29, 2018, 12:07 p.m., Benjamin Bannier wrote: > > include/mesos/mesos.proto > > Lines 1920-1921 (patched) > > > > > > These enum values are not handled in a number of switch statements in > > the code

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On March 29, 2018, 12:07 p.m., Benjamin Bannier wrote: > > include/mesos/mesos.proto > > Lines 1920-1921 (patched) > > > > > > These enum values are not handled in a number of switch statements in > > the code

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On March 29, 2018, 5:07 a.m., Benjamin Bannier wrote: > > include/mesos/mesos.proto > > Lines 1920-1921 (patched) > > > > > > These enum values are not handled in a number of switch statements in > > the code so

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review200185 --- include/mesos/mesos.proto Lines 1920-1921 (patched)

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review200142 --- Ship it! Ship It! - Greg Mann On March 28, 2018, 6:24 p.m.,

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated March 28, 2018, 11:24 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review200053 --- include/mesos/mesos.proto Lines 1970 (patched)

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated March 22, 2018, 3:36 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review199796 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 1962

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated March 20, 2018, 6:31 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review199354 --- include/mesos/mesos.proto Lines 1967 (patched)

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated March 16, 2018, 10:54 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On March 15, 2018, 7:10 p.m., Chun-Hung Hsiao wrote: > > include/mesos/mesos.proto > > Lines 1975 (patched) > > > > > > I'm thinking that, instead of asking the framework to craft the freed > > disk, we could

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On March 15, 2018, 12:10 p.m., Chun-Hung Hsiao wrote: > > include/mesos/mesos.proto > > Lines 1920-1921 (patched) > > > > > > As we discussed, let's do `s/PERSISTENT_//`, as well as > > `s/Persistent//` and

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review199283 --- include/mesos/mesos.proto Lines 1920-1921 (patched)

Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- Review request for mesos, Chun-Hung Hsiao and Gaston Kleiman. Bugs: MESOS-4965