Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

2018-04-04 Thread Gilbert Song
> On April 4, 2018, 11:23 a.m., Gilbert Song wrote: > > src/tests/containerizer/linux_capabilities_isolator_tests.cpp > > Lines 747 (patched) > > > > > > Should we call `slave.get()->terminate()` before `reset()`?

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

2018-04-04 Thread Andrei Budnik
> On April 4, 2018, 6:23 p.m., Gilbert Song wrote: > > src/tests/containerizer/linux_capabilities_isolator_tests.cpp > > Lines 747 (patched) > > > > > > Should we call `slave.get()->terminate()` before `reset()`?

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

2018-04-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66449/#review200472 --- src/tests/containerizer/linux_capabilities_isolator_tests.cpp

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

2018-04-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66449/#review200453 --- Patch looks great! Reviews applied: [66449] Passed command:

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

2018-04-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66449/#review200449 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

2018-04-04 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66449/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. Bugs: