Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

2018-06-06 Thread Qian Zhang 


> On April 18, 2018, 9:24 p.m., Qian Zhang wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp
> > Lines 493-517 (patched)
> > 
> >
> > Can you use raw string literal to avoid escaping?
> 
> Gilbert Song wrote:
> Considering all `mockHadoopScript` was written in this way. I would 
> suggest follow the style for now and refactor together in a separate patch.

Agree.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66562/#review201417
---


On June 6, 2018, 4:43 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66562/
> ---
> 
> (Updated June 6, 2018, 4:43 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-8794
> https://issues.apache.org/jira/browse/MESOS-8794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for local puller hdfs uri fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 3cb1a7ed251cf22c8609b39685da2d86b2770766 
> 
> 
> Diff: https://reviews.apache.org/r/66562/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

2018-06-06 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66562/
---

(Updated June 6, 2018, 1:43 a.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-8794
https://issues.apache.org/jira/browse/MESOS-8794


Repository: mesos


Description
---

Added test for local puller hdfs uri fetcher plugin.


Diffs (updated)
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
3cb1a7ed251cf22c8609b39685da2d86b2770766 


Diff: https://reviews.apache.org/r/66562/diff/3/

Changes: https://reviews.apache.org/r/66562/diff/2-3/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

2018-06-06 Thread Gilbert Song 


> On April 18, 2018, 6:24 a.m., Qian Zhang wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp
> > Lines 493-517 (patched)
> > 
> >
> > Can you use raw string literal to avoid escaping?

Considering all `mockHadoopScript` was written in this way. I would suggest 
follow the style for now and refactor together in a separate patch.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66562/#review201417
---


On April 16, 2018, 10:32 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66562/
> ---
> 
> (Updated April 16, 2018, 10:32 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-8794
> https://issues.apache.org/jira/browse/MESOS-8794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for local puller hdfs uri fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c664ff807583d587d94b0ab797330d5d3daf7657 
> 
> 
> Diff: https://reviews.apache.org/r/66562/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

2018-04-18 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66562/#review201417
---


Fix it, then Ship it!





src/tests/containerizer/provisioner_docker_tests.cpp
Lines 493-517 (patched)


Can you use raw string literal to avoid escaping?


- Qian Zhang


On April 17, 2018, 1:32 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66562/
> ---
> 
> (Updated April 17, 2018, 1:32 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-8794
> https://issues.apache.org/jira/browse/MESOS-8794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for local puller hdfs uri fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c664ff807583d587d94b0ab797330d5d3daf7657 
> 
> 
> Diff: https://reviews.apache.org/r/66562/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

2018-04-16 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66562/
---

(Updated April 16, 2018, 10:32 p.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-8794
https://issues.apache.org/jira/browse/MESOS-8794


Repository: mesos


Description
---

Added test for local puller hdfs uri fetcher plugin.


Diffs (updated)
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
c664ff807583d587d94b0ab797330d5d3daf7657 


Diff: https://reviews.apache.org/r/66562/diff/2/

Changes: https://reviews.apache.org/r/66562/diff/1-2/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

2018-04-11 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66562/#review200928
---



PASS: Mesos patch 66562 was successfully built and tested.

Reviews applied: `['66559', '66560', '66561', '66562']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66562

- Mesos Reviewbot Windows


On April 11, 2018, 6:31 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66562/
> ---
> 
> (Updated April 11, 2018, 6:31 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for local puller hdfs uri fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c664ff807583d587d94b0ab797330d5d3daf7657 
> 
> 
> Diff: https://reviews.apache.org/r/66562/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

2018-04-11 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66562/
---

Review request for mesos, Jie Yu and Qian Zhang.


Repository: mesos


Description
---

Added test for local puller hdfs uri fetcher plugin.


Diffs
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
c664ff807583d587d94b0ab797330d5d3daf7657 


Diff: https://reviews.apache.org/r/66562/diff/1/


Testing
---

make check


Thanks,

Gilbert Song