Re: Review Request 66648: Marked the resource provider API as experimental.

2018-04-17 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66648/#review201369
---


Ship it!




Ship It!

- Gilbert Song


On April 17, 2018, 12:22 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66648/
> ---
> 
> (Updated April 17, 2018, 12:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, Jie 
> Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8787
> https://issues.apache.org/jira/browse/MESOS-8787
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch marks the resource provider API as experimental, and make the
> v0 and v1 protos consistent.
> 
> 
> Diffs
> -
> 
>   include/mesos/resource_provider/resource_provider.proto 
> db7c751bb61fb1ee2421015dcbefc021c3afbdac 
>   include/mesos/v1/resource_provider/resource_provider.proto 
> 42bc050ed01a272603a41ab052ed75d799dd76e2 
> 
> 
> Diff: https://reviews.apache.org/r/66648/diff/2/
> 
> 
> Testing
> ---
> 
> No need for testing since only comments are changed.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 66648: Marked the resource provider API as experimental.

2018-04-17 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66648/#review201349
---



PASS: Mesos patch 66648 was successfully built and tested.

Reviews applied: `['66616', '66648']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66648

- Mesos Reviewbot Windows


On April 17, 2018, 9:22 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66648/
> ---
> 
> (Updated April 17, 2018, 9:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, Jie 
> Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8787
> https://issues.apache.org/jira/browse/MESOS-8787
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch marks the resource provider API as experimental, and make the
> v0 and v1 protos consistent.
> 
> 
> Diffs
> -
> 
>   include/mesos/resource_provider/resource_provider.proto 
> db7c751bb61fb1ee2421015dcbefc021c3afbdac 
>   include/mesos/v1/resource_provider/resource_provider.proto 
> 42bc050ed01a272603a41ab052ed75d799dd76e2 
> 
> 
> Diff: https://reviews.apache.org/r/66648/diff/2/
> 
> 
> Testing
> ---
> 
> No need for testing since only comments are changed.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 66648: Marked the resource provider API as experimental.

2018-04-17 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66648/
---

(Updated April 17, 2018, 7:22 p.m.)


Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, Jie Yu, 
and Jan Schlicht.


Changes
---

Addressed Greg's comment.


Bugs: MESOS-8787
https://issues.apache.org/jira/browse/MESOS-8787


Repository: mesos


Description (updated)
---

This patch marks the resource provider API as experimental, and make the
v0 and v1 protos consistent.


Diffs (updated)
-

  include/mesos/resource_provider/resource_provider.proto 
db7c751bb61fb1ee2421015dcbefc021c3afbdac 
  include/mesos/v1/resource_provider/resource_provider.proto 
42bc050ed01a272603a41ab052ed75d799dd76e2 


Diff: https://reviews.apache.org/r/66648/diff/2/

Changes: https://reviews.apache.org/r/66648/diff/1-2/


Testing
---

No need for testing since only comments are changed.


Thanks,

Chun-Hung Hsiao

Re: Review Request 66648: Marked the resource provider API as experimental.

2018-04-17 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66648/#review201331
---




include/mesos/resource_provider/resource_provider.proto
Lines 27 (patched)


Hmm I feel that "unstable" might imply the existence of known bugs? Perhaps 
something like "NOTE: For the time being this API is subject to change and the 
related feature is experimental."?


- Greg Mann


On April 17, 2018, 3:26 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66648/
> ---
> 
> (Updated April 17, 2018, 3:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan 
> Schlicht.
> 
> 
> Bugs: MESOS-8787
> https://issues.apache.org/jira/browse/MESOS-8787
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Marked the resource provider API as experimental.
> 
> 
> Diffs
> -
> 
>   include/mesos/resource_provider/resource_provider.proto 
> db7c751bb61fb1ee2421015dcbefc021c3afbdac 
>   include/mesos/v1/resource_provider/resource_provider.proto 
> 42bc050ed01a272603a41ab052ed75d799dd76e2 
> 
> 
> Diff: https://reviews.apache.org/r/66648/diff/1/
> 
> 
> Testing
> ---
> 
> No need for testing since only comments are changed.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 66648: Marked the resource provider API as experimental.

2018-04-17 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66648/#review201313
---



Patch looks great!

Reviews applied: [66398, 66407, 66408, 66409, 66410, 66411, 66418, 66574, 
66575, 66576, 66616, 66648]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 17, 2018, 3:26 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66648/
> ---
> 
> (Updated April 17, 2018, 3:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan 
> Schlicht.
> 
> 
> Bugs: MESOS-8787
> https://issues.apache.org/jira/browse/MESOS-8787
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Marked the resource provider API as experimental.
> 
> 
> Diffs
> -
> 
>   include/mesos/resource_provider/resource_provider.proto 
> db7c751bb61fb1ee2421015dcbefc021c3afbdac 
>   include/mesos/v1/resource_provider/resource_provider.proto 
> 42bc050ed01a272603a41ab052ed75d799dd76e2 
> 
> 
> Diff: https://reviews.apache.org/r/66648/diff/1/
> 
> 
> Testing
> ---
> 
> No need for testing since only comments are changed.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 66648: Marked the resource provider API as experimental.

2018-04-16 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66648/#review201280
---



PASS: Mesos patch 66648 was successfully built and tested.

Reviews applied: `['66616', '66648']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66648

- Mesos Reviewbot Windows


On April 16, 2018, 11:32 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66648/
> ---
> 
> (Updated April 16, 2018, 11:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8787
> https://issues.apache.org/jira/browse/MESOS-8787
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Marked the resource provider API as experimental.
> 
> 
> Diffs
> -
> 
>   include/mesos/resource_provider/resource_provider.proto 
> db7c751bb61fb1ee2421015dcbefc021c3afbdac 
>   include/mesos/v1/resource_provider/resource_provider.proto 
> 42bc050ed01a272603a41ab052ed75d799dd76e2 
> 
> 
> Diff: https://reviews.apache.org/r/66648/diff/1/
> 
> 
> Testing
> ---
> 
> No need for testing since only comments are changed.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Review Request 66648: Marked the resource provider API as experimental.

2018-04-16 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66648/
---

Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Bugs: MESOS-8787
https://issues.apache.org/jira/browse/MESOS-8787


Repository: mesos


Description
---

Marked the resource provider API as experimental.


Diffs
-

  include/mesos/resource_provider/resource_provider.proto 
db7c751bb61fb1ee2421015dcbefc021c3afbdac 
  include/mesos/v1/resource_provider/resource_provider.proto 
42bc050ed01a272603a41ab052ed75d799dd76e2 


Diff: https://reviews.apache.org/r/66648/diff/1/


Testing
---

No need for testing since only comments are changed.


Thanks,

Chun-Hung Hsiao