Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/#review203717
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67201']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (106 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1004 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (31 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (71 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (789 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (815 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (726 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (750 ms total)

[--] Global test environment tear-down
[==] 981 tests from 95 test cases ran. (91 ms total)
[  PASSED  ] 980 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] 
DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201/logs/mesos-tests-stderr.log):

```
I0524 00:03:15.625950 18136 master.cpp:10843] Updating the state of task 
8e7cde9f-4e9b-4aaa-b3b5-01b4a11c32af of framework 
4568dfbf-6df1-4556-9922-ac78f8546a15I0524 00:03:15.463933 17900 exec.cpp:162] 
Version: 1.7.0
I0524 00:03:15.488958 19436 exec.cpp:236] Executor registered on agent 
4568dfbf-6df1-4556-9922-ac78f8546a15-S0
I0524 00:03:15.492950 16680 executor.cpp:178] Received SUBSCRIBED event
I0524 00:03:15.496960 16680 executor.cpp:182] Subscribed executor on 
windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0524 00:03:15.497965 16680 executor.cpp:178] Received LAUNCH event
I0524 00:03:15.502949 16680 executor.cpp:665] Starting task 
8e7cde9f-4e9b-4aaa-b3b5-01b4a11c32af
I0524 00:03:15.582963 16680 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0524 00:03:15.599956 16680 executor.cpp:678] Forked command at 14724
I0524 00:03:15.628950 13820 exec.cpp:445] Executor asked to shutdown
I0524 00:03:15.629952 20088 executor.cpp:178] Received SHUTDOWN event
I0524 00:03:15.629952 20088 executor.cpp:781] Shutting down
I0524 00:03:15.629952 20088 executor.cpp:894] Sending SIGTERM to process tree 
at pid 14- (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0524 00:03:15.626950 16220 slave.cpp:3935] Shutting down framework 
4568dfbf-6df1-4556-9922-ac78f8546a15-
I0524 00:03:15.626950 16220 slave.cpp:6656] Shutting down executor 
'8e7cde9f-4e9b-4aaa-b3b5-01b4a11c32af' of framework 
4568dfbf-6df1-4556-9922-ac78f8546a15- at executor(1)@192.10.1.6:52473
I0524 00:03:15.628950 16220 slave.cpp:929] Agent terminating
W0524 00:03:15.628950 16220 slave.cpp:3931] Ignoring shutdown framework 
4568dfbf-6df1-4556-9922-ac78f8546a15- because it is terminating
I0524 00:03:15.629952 18136 master.cpp:10942] Removing task 
8e7cde9f-4e9b-4aaa-b3b5-01b4a11c32af with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 4568dfbf-6df1-4556-9922-ac78f8546a15- on 
agent 4568dfbf-6df1-4556-9922-ac78f8546a15-S0 at slave(448)@192.10.1.6:52452 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 00:03:15.632956 18136 master.cpp:1293] Agent 
4568dfbf-6df1-4556-9922-ac78f8546a15-S0 at slave(448)@192.10.1.6:52452 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0524 00:03:15.632956 19272 hierarchical.cpp:344] Removed framework 
4568dfbf-6df1-4556-9922-ac78f8546a15-
I0524 00:03:15.632956 18136 master.cpp:3303] Disconnecting agent 
4568dfbf-6df1-4556-9922-ac78f8546a15-S0 at slave(448)@192.10.1.6:52452 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 00:03:15.633949 18136 master.cpp:3322] Deactivating agent 
4568dfbf-6df1-4556-9922-ac78f8546a15-S0 at slave(448)@1

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/
---

(Updated May 23, 2018, 11:14 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

Whitelist handles that can be inherited by a child process.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 
  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8da612af2888ff4d4d458ea5b16cdb08779b6f4c 
  src/slave/containerizer/mesos/containerizer.cpp 
eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
  src/slave/containerizer/mesos/launcher.hpp 
f69d934d2e1a129e10df8c7f5c78723e832adc7d 
  src/slave/containerizer/mesos/launcher.cpp 
2fe47d368cb82a46328e1f636baa836272db244c 
  src/slave/containerizer/mesos/linux_launcher.hpp 
0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 
  src/slave/containerizer/mesos/linux_launcher.cpp 
80e444501e429c1e1ae354abcd51f86430316ada 


Diff: https://reviews.apache.org/r/67201/diff/10/

Changes: https://reviews.apache.org/r/67201/diff/9-10/


Testing
---


Thanks,

Radhika Jandhyala

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/#review203671
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67201']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (103 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1037 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (78 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (752 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (776 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (738 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (762 ms total)

[--] Global test environment tear-down
[==] 981 tests from 95 test cases ran. (44 ms total)
[  PASSED  ] 980 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] 
DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201/logs/mesos-tests-stderr.log):

```
I0523 17:25:33.691969 19160 master.cpp:10843] Updating the state of task 
73b63b1d-f692-4c6f-be80-ead7a3ef3dac of framework 
af7ec4d7-620e-4a34-a06d-e566cd1bb03e- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0523 17:25:33.691969 18772 slave.cpp:3935] Shutting down framework 
af7ec4d7-620e-4a34-a06d-e566cd1bb03e-
I0523 17:25:33.691969 18772 slave.cpp:6656] ShuI0523 17:25:33.530972  6476 
exec.cpp:162] Version: 1.7.0
I0523 17:25:33.556954 20112 exec.cpp:236] Executor registered on agent 
af7ec4d7-620e-4a34-a06d-e566cd1bb03e-S0
I0523 17:25:33.559967 12792 executor.cpp:178] Received SUBSCRIBED event
I0523 17:25:33.564960 12792 executor.cpp:182] Subscribed executor on 
windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0523 17:25:33.564960 12792 executor.cpp:178] Received LAUNCH event
I0523 17:25:33.569963 12792 executor.cpp:665] Starting task 
73b63b1d-f692-4c6f-be80-ead7a3ef3dac
I0523 17:25:33.649971 12792 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0523 17:25:33.666976 12792 executor.cpp:678] Forked command at 19916
I0523 17:25:33.693975  9968 exec.cpp:445] Executor asked to shutdown
I0523 17:25:33.694975 18760 executor.cpp:178] Received SHUTDOWN event
I0523 17:25:33.694975 18760 executor.cpp:781] Shutting down
I0523 17:25:33.694975 18760 executor.cpp:894] Sending SIGTERM to process tree 
at pid 19tting down executor '73b63b1d-f692-4c6f-be80-ead7a3ef3dac' of 
framework af7ec4d7-620e-4a34-a06d-e566cd1bb03e- at 
executor(1)@192.10.1.6:55743
I0523 17:25:33.693975 18772 slave.cpp:929] Agent terminating
I0523 17:25:33.693975 19160 master.cpp:10942] Removing task 
73b63b1d-f692-4c6f-be80-ead7a3ef3dac with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework af7ec4d7-620e-4a34-a06d-e566cd1bb03e- on 
agent af7ec4d7-620e-4a34-a06d-e566cd1bb03e-S0 at slave(448)@192.10.1.6:55722 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
W0523 17:25:33.694975 18772 slave.cpp:3931] Ignoring shutdown framework 
af7ec4d7-620e-4a34-a06d-e566cd1bb03e- because it is terminating
I0523 17:25:33.696956 19300 master.cpp:1293] Agent 
af7ec4d7-620e-4a34-a06d-e566cd1bb03e-S0 at slave(448)@192.10.1.6:55722 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0523 17:25:33.697974 19300 master.cpp:3303] Disconnecting agent 
af7ec4d7-620e-4a34-a06d-e566cd1bb03e-S0 at slave(448)@192.10.1.6:55722 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0523 17:25:33.697974 19792 hierarchical.cpp:344] Removed framework 
af7ec4d7-620e-4a34-a06d-e566cd1bb03e-
I0523 17:25:33.697974 19300 master.cpp:3322] Deactivating agent 
af7ec4d7-620e-4a34-a06d-e566cd1bb03e-S0 at slave(448)@

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/
---

(Updated May 23, 2018, 4:54 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

Whitelist handles that can be inherited by a child process.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 
  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8da612af2888ff4d4d458ea5b16cdb08779b6f4c 
  src/slave/containerizer/mesos/containerizer.cpp 
eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
  src/slave/containerizer/mesos/launcher.hpp 
f69d934d2e1a129e10df8c7f5c78723e832adc7d 
  src/slave/containerizer/mesos/launcher.cpp 
2fe47d368cb82a46328e1f636baa836272db244c 
  src/slave/containerizer/mesos/linux_launcher.hpp 
0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 


Diff: https://reviews.apache.org/r/67201/diff/9/

Changes: https://reviews.apache.org/r/67201/diff/8-9/


Testing
---


Thanks,

Radhika Jandhyala

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/
---

(Updated May 23, 2018, 4:40 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

Whitelist handles that can be inherited by a child process.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 
  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8da612af2888ff4d4d458ea5b16cdb08779b6f4c 
  src/slave/containerizer/mesos/containerizer.cpp 
eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
  src/slave/containerizer/mesos/launcher.hpp 
f69d934d2e1a129e10df8c7f5c78723e832adc7d 
  src/slave/containerizer/mesos/launcher.cpp 
2fe47d368cb82a46328e1f636baa836272db244c 
  src/slave/containerizer/mesos/linux_launcher.hpp 
0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 


Diff: https://reviews.apache.org/r/67201/diff/8/

Changes: https://reviews.apache.org/r/67201/diff/7-8/


Testing
---


Thanks,

Radhika Jandhyala

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/#review203603
---



PASS: Mesos patch 67201 was successfully built and tested.

Reviews applied: `['67201']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201

- Mesos Reviewbot Windows


On May 22, 2018, 8:42 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67201/
> ---
> 
> (Updated May 22, 2018, 8:42 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Whitelist handles that can be inherited by a child process.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6a1262340c333b617402637e648c12769827ffc4 
>   3rdparty/libprocess/src/subprocess.cpp 
> d7a725363251f9c54072cd7551f5598696938308 
>   3rdparty/libprocess/src/subprocess_windows.hpp 
> c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 
>   3rdparty/stout/include/stout/internal/windows/inherit.hpp 
> 7dbde820e775cbaeb8db4bc4559ab432903e75ea 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 
> 8da612af2888ff4d4d458ea5b16cdb08779b6f4c 
>   src/slave/containerizer/mesos/containerizer.cpp 
> eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
>   src/slave/containerizer/mesos/launcher.hpp 
> f69d934d2e1a129e10df8c7f5c78723e832adc7d 
>   src/slave/containerizer/mesos/launcher.cpp 
> 2fe47d368cb82a46328e1f636baa836272db244c 
>   src/slave/containerizer/mesos/linux_launcher.hpp 
> 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 
> 
> 
> Diff: https://reviews.apache.org/r/67201/diff/7/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/
---

(Updated May 22, 2018, 8:42 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Changes
---

MesosContainerizerProcess::_launch puts read write pipes into the environment 
which is used to create process. These handles need to be whitelisted as well, 
so pass them down the stack as an option


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

Whitelist handles that can be inherited by a child process.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 
  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8da612af2888ff4d4d458ea5b16cdb08779b6f4c 
  src/slave/containerizer/mesos/containerizer.cpp 
eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
  src/slave/containerizer/mesos/launcher.hpp 
f69d934d2e1a129e10df8c7f5c78723e832adc7d 
  src/slave/containerizer/mesos/launcher.cpp 
2fe47d368cb82a46328e1f636baa836272db244c 
  src/slave/containerizer/mesos/linux_launcher.hpp 
0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 


Diff: https://reviews.apache.org/r/67201/diff/7/

Changes: https://reviews.apache.org/r/67201/diff/6-7/


Testing
---


Thanks,

Radhika Jandhyala

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/#review203471
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67201']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201/logs/mesos-tests-stdout.log):

```
[   OK ] GarbageCollectorTest.Prune (11 ms)
[--] 3 tests from GarbageCollectorTest (88 ms total)

[--] 5 tests from GarbageCollectorIntegrationTest
[ RUN  ] GarbageCollectorIntegrationTest.Restart
[   OK ] GarbageCollectorIntegrationTest.Restart (415 ms)
[ RUN  ] GarbageCollectorIntegrationTest.ExitedFramework
[   OK ] GarbageCollectorIntegrationTest.ExitedFramework (289 ms)
[ RUN  ] GarbageCollectorIntegrationTest.ExitedExecutor
[   OK ] GarbageCollectorIntegrationTest.ExitedExecutor (351 ms)
[ RUN  ] GarbageCollectorIntegrationTest.DiskUsage
[   OK ] GarbageCollectorIntegrationTest.DiskUsage (300 ms)
[ RUN  ] GarbageCollectorIntegrationTest.Unschedule
[   OK ] GarbageCollectorIntegrationTest.Unschedule (343 ms)
[--] 5 tests from GarbageCollectorIntegrationTest (1775 ms total)

[--] 12 tests from HealthCheckTest
[ RUN  ] HealthCheckTest.HealthCheckProtobufValidation
[   OK ] HealthCheckTest.HealthCheckProtobufValidation (2 ms)
[ RUN  ] HealthCheckTest.HealthyTask
d:\dcos\mesos\mesos\src\tests\health_check_tests.cpp(348): error:   
Expected: TASK_STARTING
To be equal to: statusStarting->state()
  Which is: TASK_FAILED
d:\dcos\mesos\mesos\src\tests\health_check_tests.cpp(350): error: Failed to 
wait 15secs for statusRunning
d:\dcos\mesos\mesos\src\tests\health_check_tests.cpp(340): error: Actual 
function call count doesn't match EXPECT_CALL(sched, statusUpdate(&driver, 
_))...
 Expected: to be called 3 times
   Actual: called once - unsatisfied and active
[  FAILED  ] HealthCheckTest.HealthyTask (15461 ms)
[ RUN  ] HealthCheckTest.HealthyTaskNonShell
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201/logs/mesos-tests-stderr.log):

```
I0519 06:57:47.823657 17200 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249626122659468days
I0519 06:58:47.840021  2616 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249626122659468days
I0519 06:59:47.851240 13936 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249626122659468days
I0519 07:00:47.856173 13624 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249626122659468days
I0519 07:01:47.861657  2616 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249839748972384days
I0519 07:02:47.875592 10160 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249626122659468days
I0519 07:03:47.890758 15504 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249626122659468days
I0519 07:04:47.896674 10160 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249626122659468days
I0519 07:05:47.910419 15016 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249626122659468days
I0519 07:06:47.925298 10160 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249839748972384days
I0519 07:07:47.932241 16480 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249626122659468days
I0519 07:08:47.942589 14512 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249626122659468days
I0519 07:09:47.957821 15504 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249626122659468days
I0519 07:10:47.961814 15016 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249626122659468days
I0519 07:11:47.975801 15504 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249839748972384days
I0519 07:12:47.989316  2616 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249619446837188days
I0519 07:13:48.005682 16432 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249619446837188days
I0519 07:14:48.007710 13936 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249619446837188days
I0519 07:15:48.024020 14192 slave.cpp:6840] Current disk usage 29.30%. Max 
allowed age: 4.249192194211343days
I0519 07:16:48.027365 16452 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249833073150104days
I0519 07:17:48.031322 10160 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249619238217743days
I0519 07:18:48.045954 13624 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249619238217743days
I0519 07:19:48.047638 15504 slave.cpp:6840] Current disk usage 29.29%. Max 
allowed age: 4.249619238217

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/
---

(Updated May 19, 2018, 4:42 a.m.)


Review request for mesos and Andrew Schwartzmeyer.


Changes
---

The following statements should be within pipes.isSome() block
startup_info_ex.StartupInfo.hStdInput = std::get<0>(pipes.get());


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

Whitelist handles that can be inherited by a child process.


Diffs (updated)
-

  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8da612af2888ff4d4d458ea5b16cdb08779b6f4c 


Diff: https://reviews.apache.org/r/67201/diff/6/

Changes: https://reviews.apache.org/r/67201/diff/5-6/


Testing
---


Thanks,

Radhika Jandhyala

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/#review203467
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67201']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201

Relevant logs:

- 
[stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201/logs/stout-tests-stdout.log):

```
[ RUN  ] NumifyTest.HexNumberTest
[   OK ] NumifyTest.HexNumberTest (1 ms)
[--] 2 tests from NumifyTest (2 ms total)

[--] 8 tests from OptionTest
[ RUN  ] OptionTest.Min
[   OK ] OptionTest.Min (0 ms)
[ RUN  ] OptionTest.Max
[   OK ] OptionTest.Max (0 ms)
[ RUN  ] OptionTest.Comparison
[   OK ] OptionTest.Comparison (0 ms)
[ RUN  ] OptionTest.NonConstReference
[   OK ] OptionTest.NonConstReference (1 ms)
[ RUN  ] OptionTest.ArrowOperator
[   OK ] OptionTest.ArrowOperator (0 ms)
[ RUN  ] OptionTest.NonCopyable
[   OK ] OptionTest.NonCopyable (0 ms)
[ RUN  ] OptionTest.GetOrElse
[   OK ] OptionTest.GetOrElse (0 ms)
[ RUN  ] OptionTest.Hash
[   OK ] OptionTest.Hash (1 ms)
[--] 8 tests from OptionTest (8 ms total)

[--] 11 tests from OsTest
[ RUN  ] OsTest.TrivialEnvironment
[   OK ] OsTest.TrivialEnvironment (12 ms)
[ RUN  ] OsTest.Argv
[   OK ] OsTest.Argv (2 ms)
[ RUN  ] OsTest.System
```

- 
[stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201/logs/stout-tests-stderr.log):

```
Assertion failed: isSome(), file 
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\option.hpp, line 118
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201/logs/mesos-tests-stderr.log):

```
I0519 01:09:43.494822  4824 main.cpp:159] Source directory: D:\DCOS\mesos\mesos
I0519 01:09:43.496816  4824 main.cpp:160] Build directory: D:\DCOS\mesos
-
We cannot run any aufs tests because:
aufs tests not supported on non-Linux systems
-
W0519 01:09:44.012753  4824 environment.cpp:305] Testing shared container 
network namespaces on Windows. This might take up to 30 seconds...
Assertion failed: isSome(), file 
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\option.hpp, line 118
```

- Mesos Reviewbot Windows


On May 18, 2018, 10:48 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67201/
> ---
> 
> (Updated May 18, 2018, 10:48 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Whitelist handles that can be inherited by a child process.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/inherit.hpp 
> 7dbde820e775cbaeb8db4bc4559ab432903e75ea 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 
> 8da612af2888ff4d4d458ea5b16cdb08779b6f4c 
> 
> 
> Diff: https://reviews.apache.org/r/67201/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/
---

(Updated May 18, 2018, 10:48 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Changes
---

Fixed formatting


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

Whitelist handles that can be inherited by a child process.


Diffs (updated)
-

  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8da612af2888ff4d4d458ea5b16cdb08779b6f4c 


Diff: https://reviews.apache.org/r/67201/diff/5/

Changes: https://reviews.apache.org/r/67201/diff/4-5/


Testing
---


Thanks,

Radhika Jandhyala

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/
---

(Updated May 18, 2018, 10:46 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

Whitelist handles that can be inherited by a child process.


Diffs (updated)
-

  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8da612af2888ff4d4d458ea5b16cdb08779b6f4c 


Diff: https://reviews.apache.org/r/67201/diff/4/

Changes: https://reviews.apache.org/r/67201/diff/3-4/


Testing
---


Thanks,

Radhika Jandhyala

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/
---

(Updated May 18, 2018, 10:32 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

Whitelist handles that can be inherited by a child process.


Diffs (updated)
-

  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8da612af2888ff4d4d458ea5b16cdb08779b6f4c 


Diff: https://reviews.apache.org/r/67201/diff/3/

Changes: https://reviews.apache.org/r/67201/diff/2-3/


Testing
---


Thanks,

Radhika Jandhyala

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/#review203452
---




3rdparty/stout/include/stout/internal/windows/inherit.hpp
Lines 33 (patched)


Please note that the data allocated in handles needs to be alive for the 
lifetime of AttributeList


- Radhika Jandhyala


On May 18, 2018, 9:59 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67201/
> ---
> 
> (Updated May 18, 2018, 9:59 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Whitelist handles that can be inherited by a child process.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/inherit.hpp 
> 7dbde820e775cbaeb8db4bc4559ab432903e75ea 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 
> 8da612af2888ff4d4d458ea5b16cdb08779b6f4c 
> 
> 
> Diff: https://reviews.apache.org/r/67201/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/
---

(Updated May 18, 2018, 9:59 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

Whitelist handles that can be inherited by a child process.


Diffs (updated)
-

  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8da612af2888ff4d4d458ea5b16cdb08779b6f4c 


Diff: https://reviews.apache.org/r/67201/diff/2/

Changes: https://reviews.apache.org/r/67201/diff/1-2/


Testing
---


Thanks,

Radhika Jandhyala

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Radhika Jandhyala via Review Board]

> On May 17, 2018, 11:21 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/stout/include/stout/internal/windows/inherit.hpp
> > Lines 34 (patched)
> > 
> >
> > What do the second and third arguments represent?

Second argument is the number of attributes you want to update. The third one 
is reserved(windows... sigh)


> On May 17, 2018, 11:21 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/stout/include/stout/internal/windows/inherit.hpp
> > Lines 41-43 (patched)
> > 
> >
> > We should probably use a `std::unique_ptr` 
> > here for RAII.

Defined an std::vector since _PROC_THREAD_ATTRIBUTE_LIST is not defined in a 
public header


> On May 17, 2018, 11:21 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/stout/include/stout/internal/windows/inherit.hpp
> > Lines 50 (patched)
> > 
> >
> > RAII takes care of this ;)
> > 
> > I noticed below we also called `DeleteProcThreadAttributeList`. Under 
> > what conditions do we `DeleteProcThreadAttributeList` and `free`, and when 
> > do we just `free`?

DeleteProcThreadAttributeList is used to release memory when 
proc_thread_attribute_list is initialized successfully. You have to call free 
to deallocate it(due to the malloc)


> On May 17, 2018, 11:21 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/stout/include/stout/os/windows/shell.hpp
> > Line 269 (original), 270 (patched)
> > 
> >
> > Is there a `W` version of this, or is that redundant...? I don't know.

If UNICODE is defined(and it is), the function names are automatically suffixed 
wth W. I changed to W version to be consistent for now.


> On May 17, 2018, 11:21 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/stout/include/stout/os/windows/shell.hpp
> > Lines 279-291 (original), 283-306 (patched)
> > 
> >
> > (Old comment: Since the size is `constexpr` (it's always 3), I don't 
> > think we need to malloc on the heap. We can just use `std::array > 3>`.)
> > 
> > Actually, I don't think you even need `handle_array` at all. `pipes` is 
> > already a `std::array` (and `int_fd` in this case is `HANDLE`). 
> > You can use the 
> > [data()](http://en.cppreference.com/w/cpp/container/array/data) member of 
> > `std::array` to get access to the underlying `HANDLE[]`.
> 
> Andrew Schwartzmeyer wrote:
> Oops, I was rushing. `int_fd` is castable to `HANDLE` but is an 
> abstracted data type that has another field. So you'd need 
> `std::vector handles(pipes->cbegin(), pipes->cend())` and then pass 
> `handles.data()`. But still, allocated automatically with no need to rfree :)

Thanks.


- Radhika


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/#review203382
---


On May 17, 2018, 10:18 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67201/
> ---
> 
> (Updated May 17, 2018, 10:18 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Whitelist handles that can be inherited by a child process.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/inherit.hpp 
> 7dbde820e775cbaeb8db4bc4559ab432903e75ea 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 
> 8da612af2888ff4d4d458ea5b16cdb08779b6f4c 
> 
> 
> Diff: https://reviews.apache.org/r/67201/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/#review203432
---



Patch looks great!

Reviews applied: [67201]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 17, 2018, 10:18 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67201/
> ---
> 
> (Updated May 17, 2018, 10:18 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Whitelist handles that can be inherited by a child process.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/inherit.hpp 
> 7dbde820e775cbaeb8db4bc4559ab432903e75ea 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 
> 8da612af2888ff4d4d458ea5b16cdb08779b6f4c 
> 
> 
> Diff: https://reviews.apache.org/r/67201/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Andrew Schwartzmeyer]

> On May 17, 2018, 4:21 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/stout/include/stout/os/windows/shell.hpp
> > Lines 279-291 (original), 283-306 (patched)
> > 
> >
> > (Old comment: Since the size is `constexpr` (it's always 3), I don't 
> > think we need to malloc on the heap. We can just use `std::array > 3>`.)
> > 
> > Actually, I don't think you even need `handle_array` at all. `pipes` is 
> > already a `std::array` (and `int_fd` in this case is `HANDLE`). 
> > You can use the 
> > [data()](http://en.cppreference.com/w/cpp/container/array/data) member of 
> > `std::array` to get access to the underlying `HANDLE[]`.

Oops, I was rushing. `int_fd` is castable to `HANDLE` but is an abstracted data 
type that has another field. So you'd need `std::vector 
handles(pipes->cbegin(), pipes->cend())` and then pass `handles.data()`. But 
still, allocated automatically with no need to rfree :)


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/#review203382
---


On May 17, 2018, 3:18 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67201/
> ---
> 
> (Updated May 17, 2018, 3:18 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Whitelist handles that can be inherited by a child process.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/inherit.hpp 
> 7dbde820e775cbaeb8db4bc4559ab432903e75ea 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 
> 8da612af2888ff4d4d458ea5b16cdb08779b6f4c 
> 
> 
> Diff: https://reviews.apache.org/r/67201/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/#review203390
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67201']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201

Relevant logs:

- 
[stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201/logs/stout-tests-stdout.log):

```
[ RUN  ] NumifyTest.HexNumberTest
[   OK ] NumifyTest.HexNumberTest (1 ms)
[--] 2 tests from NumifyTest (2 ms total)

[--] 8 tests from OptionTest
[ RUN  ] OptionTest.Min
[   OK ] OptionTest.Min (1 ms)
[ RUN  ] OptionTest.Max
[   OK ] OptionTest.Max (0 ms)
[ RUN  ] OptionTest.Comparison
[   OK ] OptionTest.Comparison (0 ms)
[ RUN  ] OptionTest.NonConstReference
[   OK ] OptionTest.NonConstReference (0 ms)
[ RUN  ] OptionTest.ArrowOperator
[   OK ] OptionTest.ArrowOperator (0 ms)
[ RUN  ] OptionTest.NonCopyable
[   OK ] OptionTest.NonCopyable (0 ms)
[ RUN  ] OptionTest.GetOrElse
[   OK ] OptionTest.GetOrElse (0 ms)
[ RUN  ] OptionTest.Hash
[   OK ] OptionTest.Hash (1 ms)
[--] 8 tests from OptionTest (7 ms total)

[--] 11 tests from OsTest
[ RUN  ] OsTest.TrivialEnvironment
[   OK ] OsTest.TrivialEnvironment (13 ms)
[ RUN  ] OsTest.Argv
[   OK ] OsTest.Argv (2 ms)
[ RUN  ] OsTest.System
```

- 
[stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201/logs/stout-tests-stderr.log):

```
Assertion failed: isSome(), file 
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\option.hpp, line 118
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67201/logs/mesos-tests-stderr.log):

```
I0518 00:37:17.494397 11900 main.cpp:159] Source directory: D:\DCOS\mesos\mesos
I0518 00:37:17.495401 11900 main.cpp:160] Build directory: D:\DCOS\mesos
-
We cannot run any aufs tests because:
aufs tests not supported on non-Linux systems
-
W0518 00:37:18.016731 11900 environment.cpp:305] Testing shared container 
network namespaces on Windows. This might take up to 30 seconds...
Assertion failed: isSome(), file 
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\option.hpp, line 118
```

- Mesos Reviewbot Windows


On May 17, 2018, 10:18 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67201/
> ---
> 
> (Updated May 17, 2018, 10:18 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Whitelist handles that can be inherited by a child process.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/inherit.hpp 
> 7dbde820e775cbaeb8db4bc4559ab432903e75ea 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 
> 8da612af2888ff4d4d458ea5b16cdb08779b6f4c 
> 
> 
> Diff: https://reviews.apache.org/r/67201/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/#review203382
---




3rdparty/stout/include/stout/internal/windows/inherit.hpp
Lines 29 (patched)


Prefer using `*` over the Hungarian-style prefix `LP`, so 
`PROC_THREAD_ATTRIBUTE_LIST*` instead of `LPPROC_THREAD_ATTRIBUTE_LIST`.



3rdparty/stout/include/stout/internal/windows/inherit.hpp
Lines 33-34 (patched)


Nit on style: Since we're in C++ code, I try to prefix global functions 
(like system APIs) with `::`, and prefer `nullptr` to `NULL`.



3rdparty/stout/include/stout/internal/windows/inherit.hpp
Lines 34 (patched)


What do the second and third arguments represent?



3rdparty/stout/include/stout/internal/windows/inherit.hpp
Lines 41-43 (patched)


We should probably use a `std::unique_ptr` here 
for RAII.



3rdparty/stout/include/stout/internal/windows/inherit.hpp
Lines 50 (patched)


RAII takes care of this ;)

I noticed below we also called `DeleteProcThreadAttributeList`. Under what 
conditions do we `DeleteProcThreadAttributeList` and `free`, and when do we 
just `free`?



3rdparty/stout/include/stout/internal/windows/inherit.hpp
Lines 58 (patched)


Prefer a static_cast or similar over C-style casting.



3rdparty/stout/include/stout/os/windows/shell.hpp
Line 269 (original), 270 (patched)


Is there a `W` version of this, or is that redundant...? I don't know.



3rdparty/stout/include/stout/os/windows/shell.hpp
Lines 279-291 (original), 283-306 (patched)


(Old comment: Since the size is `constexpr` (it's always 3), I don't think 
we need to malloc on the heap. We can just use `std::array`.)

Actually, I don't think you even need `handle_array` at all. `pipes` is 
already a `std::array` (and `int_fd` in this case is `HANDLE`). You 
can use the [data()](http://en.cppreference.com/w/cpp/container/array/data) 
member of `std::array` to get access to the underlying `HANDLE[]`.



3rdparty/stout/include/stout/os/windows/shell.hpp
Lines 339-341 (patched)


RAII and you can delete this!


- Andrew Schwartzmeyer


On May 17, 2018, 3:18 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67201/
> ---
> 
> (Updated May 17, 2018, 3:18 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Whitelist handles that can be inherited by a child process.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/inherit.hpp 
> 7dbde820e775cbaeb8db4bc4559ab432903e75ea 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 
> 8da612af2888ff4d4d458ea5b16cdb08779b6f4c 
> 
> 
> Diff: https://reviews.apache.org/r/67201/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Review Request 67201: Whitelist handles that can be inherited by a child process.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67201/
---

Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

Whitelist handles that can be inherited by a child process.


Diffs
-

  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8da612af2888ff4d4d458ea5b16cdb08779b6f4c 


Diff: https://reviews.apache.org/r/67201/diff/1/


Testing
---


Thanks,

Radhika Jandhyala