Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/ --- (Updated Aug. 20, 2018, 11:52 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-17 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/#review207555 --- Fix it, then Ship it! src/resource_provider/manager.cpp Lines

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-16 Thread Chun-Hung Hsiao
> On Aug. 15, 2018, 8:15 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 617 (patched) > > > > > > Since we log the removing attempt above, should we also log the result > > as well? Or

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/ --- (Updated Aug. 16, 2018, 11:16 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-16 Thread Chun-Hung Hsiao
> On Aug. 15, 2018, 8:15 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 617 (patched) > > > > > > Since we log the removing attempt above, should we also log the result > > as well? Or

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-16 Thread Benjamin Bannier
> On Aug. 15, 2018, 10:15 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 611-612 (patched) > > > > > > These should be done in the agent since it knows about the task > > resources. I

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/ --- (Updated Aug. 16, 2018, 4:31 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/#review207343 --- Fix it, then Ship it! src/resource_provider/manager.cpp Lines

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-15 Thread Benjamin Bannier
> On Aug. 15, 2018, 3:57 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/message.hpp > > Lines 47 (patched) > > > > > > I was wondering that if `SUBSCRIBED`, `DISCONNECTED`, and > > `REMOVED`/`GONE` are

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/ --- (Updated Aug. 15, 2018, 3:53 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-14 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/#review207287 --- src/resource_provider/message.hpp Lines 47 (patched)

Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8403