Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

2018-08-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68307/#review207328 --- Ship it! I would prefer another wording of the description but

Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

2018-08-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68307/#review207315 --- Patch looks great! Reviews applied: [68325, 68350, 68326, 68327,

Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

2018-08-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68307/#review207288 --- PASS: Mesos patch 68307 was successfully built and tested.

Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

2018-08-14 Thread Benjamin Mahler
> On Aug. 14, 2018, 11:03 p.m., Gastón Kleiman wrote: > > src/tests/authentication_tests.cpp > > Lines 424 (patched) > > > > > > Nit: it would be more readable to use: > >

Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

2018-08-14 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68307/#review207260 --- Fix it, then Ship it! src/tests/authentication_tests.cpp

Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

2018-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68307/#review207199 --- PASS: Mesos patch 68307 was successfully built and tested.

Review Request 68307: Added a test for master's handling of stale authentication requests.

2018-08-13 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68307/ --- Review request for mesos. Bugs: MESOS-9144