Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

2018-09-27 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68404/#review209077
---



PASS: Mesos patch 68404 was successfully built and tested.

Reviews applied: `['68401', '68402', '68403', '68404']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2403/mesos-review-68404

- Mesos Reviewbot Windows


On Sept. 27, 2018, 6:12 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68404/
> ---
> 
> (Updated Sept. 27, 2018, 6:12 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the `disk/xfs` recovery tests to ensure that projects IDs on
> persistent volumes are correctly accounted for across agent restarts.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 2b3a2e25f5075357f090d47826698e7bb6fdf969 
> 
> 
> Diff: https://reviews.apache.org/r/68404/diff/6/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

2018-09-27 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68404/
---

(Updated Sept. 27, 2018, 6:12 p.m.)


Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and 
Jiang Yan Xu.


Bugs: MESOS-5158
https://issues.apache.org/jira/browse/MESOS-5158


Repository: mesos


Description
---

Updated the `disk/xfs` recovery tests to ensure that projects IDs on
persistent volumes are correctly accounted for across agent restarts.


Diffs (updated)
-

  src/tests/containerizer/xfs_quota_tests.cpp 
2b3a2e25f5075357f090d47826698e7bb6fdf969 


Diff: https://reviews.apache.org/r/68404/diff/6/

Changes: https://reviews.apache.org/r/68404/diff/5-6/


Testing
---

sudo make check (Fedora 28)


Thanks,

James Peach

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

2018-09-27 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68404/
---

(Updated Sept. 27, 2018, 6:02 p.m.)


Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and 
Jiang Yan Xu.


Bugs: MESOS-5158
https://issues.apache.org/jira/browse/MESOS-5158


Repository: mesos


Description
---

Updated the `disk/xfs` recovery tests to ensure that projects IDs on
persistent volumes are correctly accounted for across agent restarts.


Diffs (updated)
-

  src/tests/containerizer/xfs_quota_tests.cpp 
2b3a2e25f5075357f090d47826698e7bb6fdf969 


Diff: https://reviews.apache.org/r/68404/diff/5/

Changes: https://reviews.apache.org/r/68404/diff/4-5/


Testing
---

sudo make check (Fedora 28)


Thanks,

James Peach

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

2018-09-20 Thread Ilya Pronin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68404/#review208819
---




src/tests/containerizer/xfs_quota_tests.cpp
Lines 1260-1262 (patched)


Should we also check that quota is still set like we do for the sandbox?



src/tests/containerizer/xfs_quota_tests.cpp
Lines 1401-1403 (patched)


Ditto re: quota check.


- Ilya Pronin


On Aug. 16, 2018, 4:52 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68404/
> ---
> 
> (Updated Aug. 16, 2018, 4:52 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the `disk/xfs` recovery tests to ensure that projects IDs on
> persistent volumes are correctly accounted for across agent restarts.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 2b3a2e25f5075357f090d47826698e7bb6fdf969 
> 
> 
> Diff: https://reviews.apache.org/r/68404/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

2018-09-20 Thread Ilya Pronin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68404/#review208820
---


Ship it!




Ship It!

- Ilya Pronin


On Aug. 16, 2018, 4:52 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68404/
> ---
> 
> (Updated Aug. 16, 2018, 4:52 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the `disk/xfs` recovery tests to ensure that projects IDs on
> persistent volumes are correctly accounted for across agent restarts.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 2b3a2e25f5075357f090d47826698e7bb6fdf969 
> 
> 
> Diff: https://reviews.apache.org/r/68404/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

2018-09-10 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68404/#review208501
---



PASS: Mesos patch 68404 was successfully built and tested.

Reviews applied: `['68401', '68402', '68403', '68404']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2315/mesos-review-68404

- Mesos Reviewbot Windows


On Aug. 16, 2018, 4:52 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68404/
> ---
> 
> (Updated Aug. 16, 2018, 4:52 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the `disk/xfs` recovery tests to ensure that projects IDs on
> persistent volumes are correctly accounted for across agent restarts.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 2b3a2e25f5075357f090d47826698e7bb6fdf969 
> 
> 
> Diff: https://reviews.apache.org/r/68404/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

2018-09-05 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68404/#review208384
---



PASS: Mesos patch 68404 was successfully built and tested.

Reviews applied: `['68398', '68399', '68400', '68401', '68402', '68403', 
'68404']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2297/mesos-review-68404

- Mesos Reviewbot Windows


On Aug. 16, 2018, 11:52 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68404/
> ---
> 
> (Updated Aug. 16, 2018, 11:52 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the `disk/xfs` recovery tests to ensure that projects IDs on
> persistent volumes are correctly accounted for across agent restarts.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 59ec182c1c3af3978156044f03d9e3d784d51fce 
> 
> 
> Diff: https://reviews.apache.org/r/68404/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

2018-08-24 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68404/#review207935
---



Patch looks great!

Reviews applied: [68398, 68399, 68400, 68401, 68402, 68403, 68404]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 16, 2018, 11:52 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68404/
> ---
> 
> (Updated Aug. 16, 2018, 11:52 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the `disk/xfs` recovery tests to ensure that projects IDs on
> persistent volumes are correctly accounted for across agent restarts.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 59ec182c1c3af3978156044f03d9e3d784d51fce 
> 
> 
> Diff: https://reviews.apache.org/r/68404/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

2018-08-24 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68404/#review207934
---



PASS: Mesos patch 68404 was successfully built and tested.

Reviews applied: `['68398', '68399', '68400', '68401', '68402', '68403', 
'68404']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2238/mesos-review-68404

- Mesos Reviewbot Windows


On Aug. 16, 2018, 4:52 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68404/
> ---
> 
> (Updated Aug. 16, 2018, 4:52 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the `disk/xfs` recovery tests to ensure that projects IDs on
> persistent volumes are correctly accounted for across agent restarts.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 59ec182c1c3af3978156044f03d9e3d784d51fce 
> 
> 
> Diff: https://reviews.apache.org/r/68404/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

2018-08-17 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68404/#review207490
---



Patch looks great!

Reviews applied: [68398, 68399, 68400, 68401, 68402, 68403, 68404]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 16, 2018, 11:52 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68404/
> ---
> 
> (Updated Aug. 16, 2018, 11:52 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the `disk/xfs` recovery tests to ensure that projects IDs on
> persistent volumes are correctly accounted for across agent restarts.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 59ec182c1c3af3978156044f03d9e3d784d51fce 
> 
> 
> Diff: https://reviews.apache.org/r/68404/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

2018-08-16 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68404/#review207471
---



PASS: Mesos patch 68404 was successfully built and tested.

Reviews applied: `['68398', '68399', '68400', '68401', '68402', '68403', 
'68404']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2181/mesos-review-68404

- Mesos Reviewbot Windows


On Aug. 16, 2018, 11:52 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68404/
> ---
> 
> (Updated Aug. 16, 2018, 11:52 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the `disk/xfs` recovery tests to ensure that projects IDs on
> persistent volumes are correctly accounted for across agent restarts.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 59ec182c1c3af3978156044f03d9e3d784d51fce 
> 
> 
> Diff: https://reviews.apache.org/r/68404/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 68404: Updated XFS recovery tests with persistent volumes.

2018-08-16 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68404/
---

Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and 
Jiang Yan Xu.


Bugs: MESOS-5158
https://issues.apache.org/jira/browse/MESOS-5158


Repository: mesos


Description
---

Updated the `disk/xfs` recovery tests to ensure that projects IDs on
persistent volumes are correctly accounted for across agent restarts.


Diffs
-

  src/tests/containerizer/xfs_quota_tests.cpp 
59ec182c1c3af3978156044f03d9e3d784d51fce 


Diff: https://reviews.apache.org/r/68404/diff/1/


Testing
---

sudo make check (Fedora 28)


Thanks,

James Peach