Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

2018-10-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68921/#review209204 --- PASS: Mesos patch 68921 was successfully built and tested.

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

2018-10-03 Thread Gilbert Song
> On Oct. 3, 2018, 3:43 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > > Lines 2268-2270 (patched) > > > > > > Do we still need this fallback if we are confident enough?

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

2018-10-03 Thread Sergey Urbanovich
> On Oct. 3, 2018, 10:43 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > > Lines 2268-2270 (patched) > > > > > > Do we still need this fallback if we are confident

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

2018-10-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68921/#review209201 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

2018-10-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68921/#review209200 --- Ship it! Ship It! - Gilbert Song On Oct. 3, 2018, 3:36

Review Request 68921: Bring up the loopback interface using `iproute2`.

2018-10-03 Thread Sergey Urbanovich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68921/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-9270