Re: Review Request 69447: Improved wording in comments for `AgentAdded` event.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69447/#review211602 --- Ship it! Ship It! - Benjamin Bannier On Nov. 26, 2018, 6:44 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69447/ > --- > > (Updated Nov. 26, 2018, 6:44 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > The comment mentioned that `AgentAdded` events can be > sent when an agent reregisters after a master failover. > This is technically correct, but neglects to mention > that the event can also be sent when the agent reregisters > at any other point in time. > > > Diffs > - > > include/mesos/master/master.proto 80bd7c43cbb6d7df0dbd1c162cf4dda48f0e2e30 > include/mesos/v1/master/master.proto > cd41a7e8dc98753b5d2b8f93d92114fe97463636 > > > Diff: https://reviews.apache.org/r/69447/diff/1/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 69447: Improved wording in comments for `AgentAdded` event.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69447/#review210873 --- PASS: Mesos patch 69447 was successfully built and tested. Reviews applied: `['69447']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2648/mesos-review-69447 - Mesos Reviewbot Windows On Nov. 26, 2018, 9:44 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69447/ > --- > > (Updated Nov. 26, 2018, 9:44 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > The comment mentioned that `AgentAdded` events can be > sent when an agent reregisters after a master failover. > This is technically correct, but neglects to mention > that the event can also be sent when the agent reregisters > at any other point in time. > > > Diffs > - > > include/mesos/master/master.proto 80bd7c43cbb6d7df0dbd1c162cf4dda48f0e2e30 > include/mesos/v1/master/master.proto > cd41a7e8dc98753b5d2b8f93d92114fe97463636 > > > Diff: https://reviews.apache.org/r/69447/diff/1/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Review Request 69447: Improved wording in comments for `AgentAdded` event.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69447/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description --- The comment mentioned that `AgentAdded` events can be sent when an agent reregisters after a master failover. This is technically correct, but neglects to mention that the event can also be sent when the agent reregisters at any other point in time. Diffs - include/mesos/master/master.proto 80bd7c43cbb6d7df0dbd1c162cf4dda48f0e2e30 include/mesos/v1/master/master.proto cd41a7e8dc98753b5d2b8f93d92114fe97463636 Diff: https://reviews.apache.org/r/69447/diff/1/ Testing --- Thanks, Benno Evers