[GitHub] spark pull request #20546: [SPARK-20659][Core] Removing sc.getExecutorStorag...

2018-02-14 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20546#discussion_r168142034 --- Diff: core/src/main/java/org/apache/spark/SparkExecutorInfo.java --- @@ -30,4 +30,8 @@ int port(); long cacheSize(); int

[GitHub] spark pull request #20589: [SPARK-23394][UI] In RDD storage page show the ex...

2018-02-14 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/20589#discussion_r168141926 --- Diff: core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala --- @@ -198,7 +200,10 @@ private[ui] class BlockDataSource(

[GitHub] spark pull request #20546: [SPARK-20659][Core] Removing sc.getExecutorStorag...

2018-02-14 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20546#discussion_r168144704 --- Diff: core/src/main/java/org/apache/spark/SparkExecutorInfo.java --- @@ -30,4 +30,8 @@ int port(); long cacheSize(); int

[GitHub] spark issue #20598: [SPARK-23406] [SS] Enable stream-stream self-joins

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20598 **[Test build #87443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87443/testReport)** for PR 20598 at commit

[GitHub] spark issue #20608: [SPARK-23422][Core] YarnShuffleIntegrationSuite fix when...

2018-02-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20608 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20589: [SPARK-23394][UI] In RDD storage page show the ex...

2018-02-14 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20589#discussion_r168100501 --- Diff: core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala --- @@ -198,7 +200,10 @@ private[ui] class BlockDataSource(

[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...

2018-02-14 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20589 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20546: [SPARK-20659][Core] Removing sc.getExecutorStorag...

2018-02-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20546#discussion_r168137296 --- Diff: core/src/main/java/org/apache/spark/SparkExecutorInfo.java --- @@ -30,4 +30,8 @@ int port(); long cacheSize(); int

[GitHub] spark pull request #20382: [SPARK-23097][SQL][SS] Migrate text socket source...

2018-02-14 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20382#discussion_r168137288 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala --- @@ -0,0 +1,246 @@ +/* + * Licensed

[GitHub] spark issue #20607: Don't block on cleanup tasks by default

2018-02-14 Thread rkrzr
Github user rkrzr commented on the issue: https://github.com/apache/spark/pull/20607 > SPARK-3015 was fixed by setting the config to true. So by setting it to false you'd be unfixing it, no? Oh, my bad. You're right. I had only seen that it had been resolved, but not that

[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20589 **[Test build #87441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87441/testReport)** for PR 20589 at commit

[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20589 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87441/ Test PASSed. ---

[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20589 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20607: Don't block on cleanup tasks by default

2018-02-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20607 Most probably nobody bothered to check. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20606: [SPARK-23421] [SQL] Document the behavior change in SPAR...

2018-02-14 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20606 Retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20568: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-14 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20568 @mrkm4ntr I see your point. Adding a method to Murmur3 would work. The problem is that we are now going to release a `FeatureHasher` in Spark 2.3 that uses the current Murmur3

[GitHub] spark pull request #20608: [SPARK-23422][Core] YarnShuffleIntegrationSuite f...

2018-02-14 Thread gaborgsomogyi
GitHub user gaborgsomogyi opened a pull request: https://github.com/apache/spark/pull/20608 [SPARK-23422][Core] YarnShuffleIntegrationSuite fix when SPARK_PREPEN… …D_CLASSES set to 1 ## What changes were proposed in this pull request?

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20554 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87445/ Test FAILed. ---

[GitHub] spark issue #20608: [SPARK-23422][Core] YarnShuffleIntegrationSuite fix when...

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20608 **[Test build #87449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87449/testReport)** for PR 20608 at commit

[GitHub] spark issue #20568: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-14 Thread mrkm4ntr
Github user mrkm4ntr commented on the issue: https://github.com/apache/spark/pull/20568 @hvanhovell I sent an e-mail to the topic `[VOTE] Spark 2.3.0 (RC3)`. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20554 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19775: [SPARK-22343][core] Add support for publishing Spark met...

2018-02-14 Thread erikerlandson
Github user erikerlandson commented on the issue: https://github.com/apache/spark/pull/19775 Although this is not kube-specific, kubernetes deployment is a major prometheus use case. Has it been tested in a kube environment? ---

[GitHub] spark issue #20607: Don't block on cleanup tasks by default

2018-02-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20607 SPARK-3015 was fixed by setting the config to true. So by setting it to false you'd be unfixing it, no? --- - To unsubscribe,

[GitHub] spark pull request #20546: [SPARK-20659][Core] Removing sc.getExecutorStorag...

2018-02-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20546#discussion_r168143242 --- Diff: core/src/main/java/org/apache/spark/SparkExecutorInfo.java --- @@ -30,4 +30,8 @@ int port(); long cacheSize(); int

[GitHub] spark pull request #20546: [SPARK-20659][Core] Removing sc.getExecutorStorag...

2018-02-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20546#discussion_r168146172 --- Diff: core/src/main/java/org/apache/spark/SparkExecutorInfo.java --- @@ -30,4 +30,8 @@ int port(); long cacheSize(); int

[GitHub] spark issue #20598: [SPARK-23406] [SS] Enable stream-stream self-joins

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20598 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20598: [SPARK-23406] [SS] Enable stream-stream self-joins

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20598 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87443/ Test PASSed. ---

[GitHub] spark issue #20606: [SPARK-23421] [SQL] Document the behavior change in SPAR...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20606 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/894/

[GitHub] spark issue #20608: [SPARK-23422][Core] YarnShuffleIntegrationSuite fix when...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20608 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20608: [SPARK-23422][Core] YarnShuffleIntegrationSuite fix when...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20608 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20554 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20554 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87444/ Test PASSed. ---

[GitHub] spark pull request #20546: [SPARK-20659][Core] Removing sc.getExecutorStorag...

2018-02-14 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20546#discussion_r168147073 --- Diff: core/src/main/java/org/apache/spark/SparkExecutorInfo.java --- @@ -30,4 +30,8 @@ int port(); long cacheSize(); int

[GitHub] spark issue #20608: [SPARK-23422][Core] YarnShuffleIntegrationSuite fix when...

2018-02-14 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20608 cc @ConeyLiu @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20554 **[Test build #87444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87444/testReport)** for PR 20554 at commit

[GitHub] spark issue #19775: [SPARK-22343][core] Add support for publishing Spark met...

2018-02-14 Thread erikerlandson
Github user erikerlandson commented on the issue: https://github.com/apache/spark/pull/19775 I agree w/ @jerryshao that adding new deps to core isn't ideal. (Also that having #11994 would be really nice) New deps on a sub-project seems more palatable, but interested in what

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20554 **[Test build #87446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87446/testReport)** for PR 20554 at commit

[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...

2018-02-14 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20605 This seems good to me. My only concern is that we still have to rely/maintain a list of exceptions thrown when the stop method is called... This approach seems not very robust to me, but I don't

[GitHub] spark pull request #20601: [SPARK-23413][UI] Fix sorting tasks by Host / Exe...

2018-02-14 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20601#discussion_r168103464 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -963,33 +965,60 @@ private[ui] class TaskPagedTable( private

[GitHub] spark pull request #20601: [SPARK-23413][UI] Fix sorting tasks by Host / Exe...

2018-02-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20601#discussion_r168105632 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -963,33 +965,60 @@ private[ui] class TaskPagedTable( private object

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20554 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/892/

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20554 **[Test build #87445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87445/testReport)** for PR 20554 at commit

[GitHub] spark pull request #20546: [SPARK-20659][Core] Removing sc.getExecutorStorag...

2018-02-14 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20546#discussion_r168136979 --- Diff: core/src/main/java/org/apache/spark/SparkExecutorInfo.java --- @@ -30,4 +30,8 @@ int port(); long cacheSize(); int

[GitHub] spark issue #20606: [SPARK-23421] [SQL] Document the behavior change in SPAR...

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20606 **[Test build #87442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87442/testReport)** for PR 20606 at commit

[GitHub] spark issue #20606: [SPARK-23421] [SQL] Document the behavior change in SPAR...

2018-02-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20606 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20597: [MINOR][TEST] Update from 2.2.0 to 2.2.1 in HiveExternal...

2018-02-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20597 Just submitted a PR https://github.com/apache/spark/pull/20606 --- - To unsubscribe, e-mail:

[GitHub] spark issue #20598: [SPARK-23406] [SS] Enable stream-stream self-joins

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20598 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/890/

[GitHub] spark issue #20598: [SPARK-23406] [SS] Enable stream-stream self-joins

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20598 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20601: [SPARK-23413][UI] Fix sorting tasks by Host / Executor I...

2018-02-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20601 I'm trying to think of a way that we can avoid these issues going forward - not that I expect this code to change much. Maybe have a unit test that makes sure all declared header constants are

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20554 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20607: Don't block on cleanup tasks by default

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20607 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20601: [SPARK-23413][UI] Fix sorting tasks by Host / Exe...

2018-02-14 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20601#discussion_r168102644 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -963,33 +965,60 @@ private[ui] class TaskPagedTable( private

[GitHub] spark issue #20568: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-14 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20568 How about add a new config to control whether to use the new Murmur3 hash function and have that default turned off? We also have to document the change explicitly. WDYT @gatorsmile

[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...

2018-02-14 Thread jose-torres
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20605 LGTM also. I'll still take it as an action item to try and think of a cleaner way to handle stopping a stream. --- - To

[GitHub] spark pull request #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source...

2018-02-14 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20554#discussion_r168120568 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchReader.scala --- @@ -0,0 +1,410 @@ +/* + * Licensed to

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20554 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20554 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/893/

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20554 **[Test build #87446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87446/testReport)** for PR 20554 at commit

[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20589 **[Test build #87441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87441/testReport)** for PR 20589 at commit

[GitHub] spark pull request #20598: [SPARK-23406] [SS] Enable stream-stream self-join...

2018-02-14 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20598#discussion_r168110951 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingRelation.scala --- @@ -62,7 +64,7 @@ case class

[GitHub] spark issue #20598: [SPARK-23406] [SS] Enable stream-stream self-joins

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20598 **[Test build #87443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87443/testReport)** for PR 20598 at commit

[GitHub] spark issue #20596: [SPARK-23404][CORE]When the underlying buffers are direc...

2018-02-14 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20596 +1 on knowing the case you want to fix here. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20606: [SPARK-23421] [SQL] Document the behavior change ...

2018-02-14 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/20606 [SPARK-23421] [SQL] Document the behavior change in SPARK-22356 ## What changes were proposed in this pull request? https://github.com/apache/spark/pull/19579 introduces a behavior change.

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20554 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20554 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/891/

[GitHub] spark issue #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source to v2

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20554 **[Test build #87444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87444/testReport)** for PR 20554 at commit

[GitHub] spark issue #20606: [SPARK-23421] [SQL] Document the behavior change in SPAR...

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20606 **[Test build #87442 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87442/testReport)** for PR 20606 at commit

[GitHub] spark issue #20606: [SPARK-23421] [SQL] Document the behavior change in SPAR...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20606 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87442/ Test FAILed. ---

[GitHub] spark pull request #20382: [SPARK-23097][SQL][SS] Migrate text socket source...

2018-02-14 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20382#discussion_r168138470 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala --- @@ -0,0 +1,246 @@ +/* + * Licensed

[GitHub] spark issue #20600: [SPARK-23412][ML] Add cosine distance to BisectingKMeans

2018-02-14 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20600 cc @srowen @viirya @zhengruifeng --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20555: [SPARK-23366] Improve hot reading path in ReadAheadInput...

2018-02-14 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20555 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20606: [SPARK-23421] [SQL] Document the behavior change in SPAR...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20606 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20607: Don't block on cleanup tasks by default

2018-02-14 Thread rkrzr
GitHub user rkrzr opened a pull request: https://github.com/apache/spark/pull/20607 Don't block on cleanup tasks by default This PR sets `"spark.cleaner.referenceTracking.blocking"` to `false` by default. It had originally been set to `true` as a workaround for SPARK-3015.

[GitHub] spark issue #20594: [SPARK-23377][ML] Fixes Bucketizer with multiple columns...

2018-02-14 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20594 @WeichenXu123 @viirya as I said in the other PR, I think no default value should be persisted. #20410 and #18982 are not regression: they are problem which have been present in all the release so

[GitHub] spark issue #20606: [SPARK-23421] [SQL] Document the behavior change in SPAR...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20606 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/889/

[GitHub] spark issue #20606: [SPARK-23421] [SQL] Document the behavior change in SPAR...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20606 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20599: [SPARK-23407][SQL] add a config to try to inline ...

2018-02-14 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/20599#discussion_r168101849 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -675,6 +675,16 @@ object SQLConf { "disable logging

[GitHub] spark issue #20607: Don't block on cleanup tasks by default

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20607 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...

2018-02-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20549 This doesn't even merge, so tests can't run. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20601: [SPARK-23413][UI] Fix sorting tasks by Host / Exe...

2018-02-14 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/20601#discussion_r168223637 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -963,33 +965,60 @@ private[ui] class TaskPagedTable( private

[GitHub] spark pull request #20549: SPARK-18844[MLLIB] Add more binary classification...

2018-02-14 Thread sandecho
Github user sandecho closed the pull request at: https://github.com/apache/spark/pull/20549 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20589 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20589 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87447/ Test PASSed. ---

[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...

2018-02-14 Thread sandecho
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20549 Can you please run the test again? [SPARK-JIRA-18844.zip](https://github.com/apache/spark/files/1724418/SPARK-JIRA-18844.zip) ---

[GitHub] spark issue #20567: [SPARK-23380][PYTHON] Make toPandas fallback to non-Arro...

2018-02-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20567 @gatorsmile and @rxin, The problem here is that `toPandas` just fails on unsupported types later and allows `BinaryType` with inconsistent conversion

[GitHub] spark issue #17275: SPARK-19767 Add note about missing API doc for Kafka 0.1...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17275 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20589: [SPARK-23394][UI] In RDD storage page show the ex...

2018-02-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20589 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20609: SPARK-18844[MLLIB] Add more binary classification metric...

2018-02-14 Thread sandecho
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20609 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20609: SPARK-18844[MLLIB] Add more binary classification metric...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20609 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20609: SPARK-18844[MLLIB] Add more binary classification...

2018-02-14 Thread sandecho
Github user sandecho closed the pull request at: https://github.com/apache/spark/pull/20609 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20609: SPARK-18844[MLLIB] Add more binary classification...

2018-02-14 Thread sandecho
Github user sandecho closed the pull request at: https://github.com/apache/spark/pull/20609 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20549 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20601: [SPARK-23413][UI] Fix sorting tasks by Host / Exe...

2018-02-14 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20601#discussion_r168211371 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -963,33 +965,60 @@ private[ui] class TaskPagedTable( private object

[GitHub] spark issue #20606: [SPARK-23421] [SQL] Document the behavior change in SPAR...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20606 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87448/ Test PASSed. ---

[GitHub] spark issue #20606: [SPARK-23421] [SQL] Document the behavior change in SPAR...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20606 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20606: [SPARK-23421] [SQL] Document the behavior change in SPAR...

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20606 **[Test build #87448 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87448/testReport)** for PR 20606 at commit

[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...

2018-02-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20589 Merging to master / 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20549: SPARK-18844[MLLIB] Add more binary classification...

2018-02-14 Thread sandecho
GitHub user sandecho reopened a pull request: https://github.com/apache/spark/pull/20549 SPARK-18844[MLLIB] Add more binary classification metrics to BinaryClassificationMetrics ## What changes were proposed in this pull request? In this PR, more binary classification

[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20549 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...

2018-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20589 **[Test build #87447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87447/testReport)** for PR 20589 at commit

  1   2   3   4   >