[GitHub] [spark] SaurabhChawla100 commented on a change in pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

2020-07-14 Thread GitBox
SaurabhChawla100 commented on a change in pull request #29045: URL: https://github.com/apache/spark/pull/29045#discussion_r454120426 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala ## @@ -179,12 +179,17 @@ class

[GitHub] [spark] SparkQA commented on pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-14 Thread GitBox
SparkQA commented on pull request #29095: URL: https://github.com/apache/spark/pull/29095#issuecomment-657990059 **[Test build #125804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125804/testReport)** for PR 29095 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29093: [SPARK-32220][SQL][3.0][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29093: URL: https://github.com/apache/spark/pull/29093#issuecomment-657989500 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #29095: URL: https://github.com/apache/spark/pull/29095#issuecomment-657990273 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29093: [SPARK-32220][SQL][3.0][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #29093: URL: https://github.com/apache/spark/pull/29093#issuecomment-657989500 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] viirya commented on pull request #29018: [SPARK-32202][ML][WIP] tree models auto infer compact integer type

2020-07-14 Thread GitBox
viirya commented on pull request #29018: URL: https://github.com/apache/spark/pull/29018#issuecomment-657993178 Despite the significant memory save, I'm also not sure how often memory is an issue when training the model. I guess CPU is more important here. This win only happens when

[GitHub] [spark] SparkQA commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-14 Thread GitBox
SparkQA commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-657993700 **[Test build #125795 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125795/testReport)** for PR 28898 at commit

[GitHub] [spark] SaurabhChawla100 commented on a change in pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

2020-07-14 Thread GitBox
SaurabhChawla100 commented on a change in pull request #29045: URL: https://github.com/apache/spark/pull/29045#discussion_r454128710 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala ## @@ -116,47 +116,53 @@ object OrcUtils

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
HyukjinKwon commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454129942 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -2353,6 +2355,53 @@ abstract class

[GitHub] [spark] viirya commented on a change in pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-14 Thread GitBox
viirya commented on a change in pull request #29086: URL: https://github.com/apache/spark/pull/29086#discussion_r454132901 ## File path: dev/run-tests.py ## @@ -589,43 +627,74 @@ def main(): # /home/jenkins/anaconda2/envs/py36/bin os.environ["PATH"] =

[GitHub] [spark] beliefer edited a comment on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-14 Thread GitBox
beliefer edited a comment on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-657998428 @maropu I'm sorry! Because the change of https://github.com/apache/spark/pull/27428, each filter clause will be converted to be normal plan. It seems we not need this

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
HyukjinKwon commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454135608 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -2353,6 +2355,53 @@ abstract class

[GitHub] [spark] izchen edited a comment on pull request #29028: [SPARK-32212][CORE]RDD.takeOrdered can choose to merge intermediate r…

2020-07-14 Thread GitBox
izchen edited a comment on pull request #29028: URL: https://github.com/apache/spark/pull/29028#issuecomment-657111204 > I'd rather not expose yet another config for this. Are there any heuristics that can select this more intelligently? Thank you very much for code review.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658001379 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658001379 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-14 Thread GitBox
HyukjinKwon commented on a change in pull request #29086: URL: https://github.com/apache/spark/pull/29086#discussion_r454144037 ## File path: dev/run-tests.py ## @@ -589,43 +627,74 @@ def main(): # /home/jenkins/anaconda2/envs/py36/bin os.environ["PATH"] =

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658006936 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] huaxingao commented on a change in pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-14 Thread GitBox
huaxingao commented on a change in pull request #28960: URL: https://github.com/apache/spark/pull/28960#discussion_r454144678 ## File path: mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala ## @@ -226,45 +239,48 @@ object GradientDescent extends

[GitHub] [spark] AmplabJenkins commented on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658006936 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-658009628 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-658009729 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-658009462 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #29087: URL: https://github.com/apache/spark/pull/29087#issuecomment-658009765 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-14 Thread GitBox
SparkQA removed a comment on pull request #29087: URL: https://github.com/apache/spark/pull/29087#issuecomment-657914322 **[Test build #125797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125797/testReport)** for PR 29087 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-14 Thread GitBox
SparkQA removed a comment on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658000826 **[Test build #125808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125808/testReport)** for PR 28917 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
SparkQA removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657995711 **[Test build #125807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125807/testReport)** for PR 29088 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658009391 Build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] SparkQA removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-14 Thread GitBox
SparkQA removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-657987750 **[Test build #125806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125806/testReport)** for PR 28708 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-658009729 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658009351 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-14 Thread GitBox
SparkQA removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-657963838 **[Test build #125803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125803/testReport)** for PR 28939 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-658009628 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-658009630 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-658009737 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29087: URL: https://github.com/apache/spark/pull/29087#issuecomment-658009765 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-658009412 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-658009471 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658009362 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-658009403 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-14 Thread GitBox
SparkQA removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-657973941 **[Test build #125805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125805/testReport)** for PR 28901 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-658000525 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29087: URL: https://github.com/apache/spark/pull/29087#issuecomment-658009772 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] viirya commented on a change in pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-14 Thread GitBox
viirya commented on a change in pull request #29086: URL: https://github.com/apache/spark/pull/29086#discussion_r454151281 ## File path: dev/run-tests.py ## @@ -589,43 +627,74 @@ def main(): # /home/jenkins/anaconda2/envs/py36/bin os.environ["PATH"] =

[GitHub] [spark] HyukjinKwon opened a new pull request #29096: [WIP][TESTS] Enable test-dependencies.sh and Unidoc test in Jenkins jobs

2020-07-14 Thread GitBox
HyukjinKwon opened a new pull request #29096: URL: https://github.com/apache/spark/pull/29096 ### What changes were proposed in this pull request? Seems like Jenkins machines came back to normal. Maybe we should just re-enable dependency test and Javadoc/Scaladoc build in Jenkins

[GitHub] [spark] SparkQA commented on pull request #29096: [WIP][TESTS] Enable test-dependencies.sh and Unidoc test in Jenkins jobs

2020-07-14 Thread GitBox
SparkQA commented on pull request #29096: URL: https://github.com/apache/spark/pull/29096#issuecomment-658018293 **[Test build #125811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125811/testReport)** for PR 29096 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29096: [WIP][TESTS] Enable test-dependencies.sh and Unidoc test in Jenkins jobs

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29096: URL: https://github.com/apache/spark/pull/29096#issuecomment-658018964 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29096: [WIP][TESTS] Enable test-dependencies.sh and Unidoc test in Jenkins jobs

2020-07-14 Thread GitBox
SparkQA removed a comment on pull request #29096: URL: https://github.com/apache/spark/pull/29096#issuecomment-658018293 **[Test build #125811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125811/testReport)** for PR 29096 at commit

[GitHub] [spark] SparkQA commented on pull request #29096: [WIP][TESTS] Enable test-dependencies.sh and Unidoc test in Jenkins jobs

2020-07-14 Thread GitBox
SparkQA commented on pull request #29096: URL: https://github.com/apache/spark/pull/29096#issuecomment-658019061 **[Test build #125811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125811/testReport)** for PR 29096 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29096: [WIP][TESTS] Enable test-dependencies.sh and Unidoc test in Jenkins jobs

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #29096: URL: https://github.com/apache/spark/pull/29096#issuecomment-658018964 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29096: [WIP][TESTS] Enable test-dependencies.sh and Unidoc test in Jenkins jobs

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29096: URL: https://github.com/apache/spark/pull/29096#issuecomment-658019090 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] joanjiao2016 commented on pull request #21038: [SPARK-22968][DStream] Throw an exception on partition revoking issue

2020-07-14 Thread GitBox
joanjiao2016 commented on pull request #21038: URL: https://github.com/apache/spark/pull/21038#issuecomment-658020895 @koeninger Hi, we have prepared two spark streaming applications with the same group id to run respectively on different cluster for disaster recovery,the first

[GitHub] [spark] SparkQA commented on pull request #29096: [WIP][TESTS] Enable test-dependencies.sh and Unidoc test in Jenkins jobs

2020-07-14 Thread GitBox
SparkQA commented on pull request #29096: URL: https://github.com/apache/spark/pull/29096#issuecomment-658021416 **[Test build #125812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125812/testReport)** for PR 29096 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29096: [WIP][TESTS] Enable test-dependencies.sh and Unidoc test in Jenkins jobs

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29096: URL: https://github.com/apache/spark/pull/29096#issuecomment-658021945 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] ulysses-you commented on a change in pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-14 Thread GitBox
ulysses-you commented on a change in pull request #28840: URL: https://github.com/apache/spark/pull/28840#discussion_r454162497 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala ## @@ -236,6 +236,45 @@ case class

[GitHub] [spark] AmplabJenkins commented on pull request #29096: [WIP][TESTS] Enable test-dependencies.sh and Unidoc test in Jenkins jobs

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #29096: URL: https://github.com/apache/spark/pull/29096#issuecomment-658021945 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] wangyum commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
wangyum commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454167871 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -2353,6 +2355,53 @@ abstract class CSVSuite

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658028313 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
HyukjinKwon commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454170678 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -2353,6 +2355,53 @@ abstract class

[GitHub] [spark] SparkQA removed a comment on pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-14 Thread GitBox
SparkQA removed a comment on pull request #29095: URL: https://github.com/apache/spark/pull/29095#issuecomment-657967512 **[Test build #125804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125804/testReport)** for PR 29095 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29095: URL: https://github.com/apache/spark/pull/29095#issuecomment-657990273 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
HyukjinKwon commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657994072 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA removed a comment on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-14 Thread GitBox
SparkQA removed a comment on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-657904652 **[Test build #125795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125795/testReport)** for PR 28898 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-657994219 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-657994219 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657996178 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
SparkQA commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657995711 **[Test build #125807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125807/testReport)** for PR 29088 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657996178 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
HyukjinKwon commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454134455 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CsvOutputWriter.scala ## @@ -39,6 +39,10 @@ class

[GitHub] [spark] beliefer commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-14 Thread GitBox
beliefer commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-657998428 @maropu I'm sorry! Because the change of https://github.com/apache/spark/pull/27428, each filter clause will be converted to be normal plan. So we not need this PR again.

[GitHub] [spark] beliefer commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-14 Thread GitBox
beliefer commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658000356 cc @jiangxb1987 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-14 Thread GitBox
SparkQA commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658000826 **[Test build #125808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125808/testReport)** for PR 28917 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-658000513 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-658000513 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
HyukjinKwon commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454139593 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala ## @@ -135,6 +135,8 @@ class CSVOptions( val

[GitHub] [spark] SparkQA commented on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-14 Thread GitBox
SparkQA commented on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658003670 **[Test build #125809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125809/testReport)** for PR 28960 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658004084 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658004084 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] jiangxb1987 commented on a change in pull request #29015: [SPARK-32215] Expose a (protected) /workers/kill endpoint on the MasterWebUI

2020-07-14 Thread GitBox
jiangxb1987 commented on a change in pull request #29015: URL: https://github.com/apache/spark/pull/29015#discussion_r454137251 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -863,7 +872,29 @@ private[deploy] class Master( true }

[GitHub] [spark] SparkQA commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-14 Thread GitBox
SparkQA commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-658009289 **[Test build #125805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125805/testReport)** for PR 28901 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658009391 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-14 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-658009287 **[Test build #125806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125806/testReport)** for PR 28708 at commit

[GitHub] [spark] SparkQA commented on pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-14 Thread GitBox
SparkQA commented on pull request #29087: URL: https://github.com/apache/spark/pull/29087#issuecomment-658009286 **[Test build #125797 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125797/testReport)** for PR 29087 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-14 Thread GitBox
SparkQA removed a comment on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658003670 **[Test build #125809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125809/testReport)** for PR 28960 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658009351 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-14 Thread GitBox
HyukjinKwon commented on a change in pull request #29086: URL: https://github.com/apache/spark/pull/29086#discussion_r454146710 ## File path: dev/run-tests.py ## @@ -589,43 +627,74 @@ def main(): # /home/jenkins/anaconda2/envs/py36/bin os.environ["PATH"] =

[GitHub] [spark] SparkQA commented on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-14 Thread GitBox
SparkQA commented on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658009295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
SparkQA commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-658009294 **[Test build #125807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125807/testReport)** for PR 29088 at commit

[GitHub] [spark] SparkQA commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-14 Thread GitBox
SparkQA commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658009292 **[Test build #125808 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125808/testReport)** for PR 28917 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-658009403 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-14 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-658009291 **[Test build #125803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125803/testReport)** for PR 28939 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #29096: [WIP][TESTS] Enable test-dependencies.sh and Unidoc test in Jenkins jobs

2020-07-14 Thread GitBox
HyukjinKwon commented on pull request #29096: URL: https://github.com/apache/spark/pull/29096#issuecomment-658016315 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HyukjinKwon commented on pull request #29096: [WIP][TESTS] Enable test-dependencies.sh and Unidoc test in Jenkins jobs

2020-07-14 Thread GitBox
HyukjinKwon commented on pull request #29096: URL: https://github.com/apache/spark/pull/29096#issuecomment-658028639 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] beliefer commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-14 Thread GitBox
beliefer commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658027966 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-14 Thread GitBox
AmplabJenkins commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658028313 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] peter-toth commented on pull request #29053: [SPARK-32241][SQL] Remove empty children of union

2020-07-14 Thread GitBox
peter-toth commented on pull request #29053: URL: https://github.com/apache/spark/pull/29053#issuecomment-658028307 Thanks for the review. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on a change in pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

2020-07-14 Thread GitBox
cloud-fan commented on a change in pull request #29045: URL: https://github.com/apache/spark/pull/29045#discussion_r454122245 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala ## @@ -116,47 +116,53 @@ object OrcUtils extends

[GitHub] [spark] holdenk commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-14 Thread GitBox
holdenk commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-657985918 Jenkins retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-14 Thread GitBox
AngersZh commented on a change in pull request #29087: URL: https://github.com/apache/spark/pull/29087#discussion_r454102278 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -496,7 +496,9 @@ fromStatementBody

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-14 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-657987750 **[Test build #125806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125806/testReport)** for PR 28708 at commit

[GitHub] [spark] SparkQA commented on pull request #29093: [SPARK-32220][SQL][3.0][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-14 Thread GitBox
SparkQA commented on pull request #29093: URL: https://github.com/apache/spark/pull/29093#issuecomment-657988627 **[Test build #125796 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125796/testReport)** for PR 29093 at commit

  1   2   3   4   5   6   7   8   9   10   >