[GitHub] [spark] HeartSaVioR commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-05-22 Thread GitBox
HeartSaVioR commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-632677209 Yeah I've indicated you're triggering builds continuously so guessed you might be stuck on reviewing, but realized you've already got +1 so wondered. Thanks for the

[GitHub] [spark] HeartSaVioR commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-05-21 Thread GitBox
HeartSaVioR commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-632449300 Hi @maropu, one question from curiosity. I guess you've already got +1 from @kiszk, so unless you haven't made non-trivial change afterwards why don't you just go