[GitHub] [spark] HeartSaVioR commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-05-22 Thread GitBox


HeartSaVioR commented on pull request #27019:
URL: https://github.com/apache/spark/pull/27019#issuecomment-632677209


   Yeah I've indicated you're triggering builds continuously so guessed you 
might be stuck on reviewing, but realized you've already got +1 so wondered. 
Thanks for the explanation!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HeartSaVioR commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-05-21 Thread GitBox


HeartSaVioR commented on pull request #27019:
URL: https://github.com/apache/spark/pull/27019#issuecomment-632449300


   Hi @maropu, one question from curiosity.
   
   I guess you've already got +1 from @kiszk, so unless you haven't made 
non-trivial change afterwards why don't you just go merge? Is there something 
you'd like to get reviewed, or is there someone you want to get reviewed before 
merging? If you are waiting for anything it would be nice to describe what 
you're waiting for.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org