[GitHub] [spark] HyukjinKwon commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-09-15 Thread GitBox
HyukjinKwon commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-531626835 > another option in my mind is applying this rule in master and branch-2.4 together. It will reduce

[GitHub] [spark] HyukjinKwon commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-09-15 Thread GitBox
HyukjinKwon commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-531572423 There seems, I suspect, one objection at

[GitHub] [spark] HyukjinKwon commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-18 Thread GitBox
HyukjinKwon commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-522324073 If we turn to `warn`, then we won't have to change a lot of instances here, Yes. But one concern is

[GitHub] [spark] HyukjinKwon commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-17 Thread GitBox
HyukjinKwon commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-522233720 retest this please This is an

[GitHub] [spark] HyukjinKwon commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-16 Thread GitBox
HyukjinKwon commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-521897289 I'm fine. WDYT guys? This is an