[GitHub] [spark] HyukjinKwon commented on pull request #28603: [SPARK-31788][CORE] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox


HyukjinKwon commented on pull request #28603:
URL: https://github.com/apache/spark/pull/28603#issuecomment-632971649


   ok to test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28603: [SPARK-31788][CORE] Fix UnionRDD of PairRDDs

2020-05-21 Thread GitBox


HyukjinKwon commented on pull request #28603:
URL: https://github.com/apache/spark/pull/28603#issuecomment-632437124


   Shell as also add a unit test? Also, please describe before/after this fix 
in "Does this PR introduce any user-facing change?". Technically I think this 
IS a user-facing behaviour changes from error to working case.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org