[GitHub] [spark] MaxGekk commented on a diff in pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files

2022-12-05 Thread GitBox 


MaxGekk commented on code in PR #37725:
URL: https://github.com/apache/spark/pull/37725#discussion_r1039856927


##
sql/core/src/test/resources/sql-tests/results/udaf.sql.out:
##
@@ -31,7 +31,12 @@ SELECT default.myDoubleAvg(int_col1, 3) as my_avg from t1
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-Invalid number of arguments for function spark_catalog.default.mydoubleavg. 
Expected: 1; Found: 2; line 1 pos 7
+{
+  "errorClass" : "LEGACY",
+  "messageParameters" : {
+"message" : "Invalid number of arguments for function 
spark_catalog.default.mydoubleavg. Expected: 1; Found: 2; line 1 pos 7"

Review Comment:
   This one should disappear after https://github.com/apache/spark/pull/38919



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] MaxGekk commented on a diff in pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files

2022-11-22 Thread GitBox 


MaxGekk commented on code in PR #37725:
URL: https://github.com/apache/spark/pull/37725#discussion_r1029406863


##
sql/core/src/test/resources/sql-tests/results/udaf.sql.out:
##
@@ -48,7 +53,12 @@ SELECT default.udaf1(int_col1) as udaf1 from t1
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-Can not load class 'test.non.existent.udaf' when registering the function 
'spark_catalog.default.udaf1', please make sure it is on the classpath; line 1 
pos 7
+{
+  "errorClass" : "LEGACY",
+  "messageParameters" : {
+"message" : "Can not load class 'test.non.existent.udaf' when registering 
the function 'spark_catalog.default.udaf1', please make sure it is on the 
classpath; line 1 pos 7"

Review Comment:
   @panbingkun Any ideas why we still don't see the error class 
`CANNOT_LOAD_FUNCTION_CLASS ` introduced by your PR 
https://github.com/apache/spark/pull/38696?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] MaxGekk commented on a diff in pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files

2022-11-17 Thread GitBox 


MaxGekk commented on code in PR #37725:
URL: https://github.com/apache/spark/pull/37725#discussion_r1025206912


##
sql/core/src/test/resources/sql-tests/results/ansi/string-functions.sql.out:
##
@@ -5,7 +5,12 @@ select concat_ws()
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-requirement failed: concat_ws requires at least one argument.; line 1 pos 7
+{
+  "errorClass" : "LEGACY",
+  "messageParameters" : {
+"message" : "requirement failed: concat_ws requires at least one 
argument.; line 1 pos 7"

Review Comment:
   SPARK-41173



##
sql/core/src/test/resources/sql-tests/results/ansi/string-functions.sql.out:
##
@@ -14,7 +19,12 @@ select format_string()
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-requirement failed: format_string() should take at least 1 argument; line 1 
pos 7
+{
+  "errorClass" : "LEGACY",
+  "messageParameters" : {
+"message" : "requirement failed: format_string() should take at least 1 
argument; line 1 pos 7"

Review Comment:
   SPARK-41173



##
sql/core/src/test/resources/sql-tests/results/ansi/string-functions.sql.out:
##
@@ -1579,7 +1589,12 @@ select to_binary('abc', 1)
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-The 'format' parameter of function 'to_binary' needs to be a string literal.; 
line 1 pos 7
+{
+  "errorClass" : "LEGACY",
+  "messageParameters" : {
+"message" : "The 'format' parameter of function 'to_binary' needs to be a 
string literal.; line 1 pos 7"

Review Comment:
   SPARK-41174



##
sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-join.sql.out:
##
@@ -3263,7 +3268,12 @@ select * from
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-Reference 'f1' is ambiguous, could be: j.f1, j.f1.; line 2 pos 72
+{
+  "errorClass" : "LEGACY",
+  "messageParameters" : {
+"message" : "Reference 'f1' is ambiguous, could be: j.f1, j.f1.; line 2 
pos 72"

Review Comment:
   SPARK-41172



##
sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-join.sql.out:
##
@@ -546,7 +546,12 @@ SELECT udf('') AS `xxx`, udf(i) AS i, udf(k), udf(t) AS t
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-Reference 'i' is ambiguous, could be: spark_catalog.default.j1_tbl.i, 
spark_catalog.default.j2_tbl.i.; line 1 pos 29
+{
+  "errorClass" : "LEGACY",
+  "messageParameters" : {
+"message" : "Reference 'i' is ambiguous, could be: 
spark_catalog.default.j1_tbl.i, spark_catalog.default.j2_tbl.i.; line 1 pos 29"

Review Comment:
   SPARK-41172



##
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out:
##
@@ -105,7 +125,12 @@ SELECT t1.i1 FROM t1, mydb2.t1
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-Reference 't1.i1' is ambiguous, could be: spark_catalog.mydb1.t1.i1, 
spark_catalog.mydb2.t1.i1.; line 1 pos 7
+{
+  "errorClass" : "LEGACY",
+  "messageParameters" : {
+"message" : "Reference 't1.i1' is ambiguous, could be: 
spark_catalog.mydb1.t1.i1, spark_catalog.mydb2.t1.i1.; line 1 pos 7"

Review Comment:
   SPARK-41172



##
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out:
##
@@ -122,7 +147,12 @@ SELECT i1 FROM t1, mydb1.t1
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-Reference 'i1' is ambiguous, could be: spark_catalog.mydb2.t1.i1, 
spark_catalog.mydb1.t1.i1.; line 1 pos 7
+{
+  "errorClass" : "LEGACY",
+  "messageParameters" : {
+"message" : "Reference 'i1' is ambiguous, could be: 
spark_catalog.mydb2.t1.i1, spark_catalog.mydb1.t1.i1.; line 1 pos 7"

Review Comment:
   SPARK-41172



##
sql/core/src/test/resources/sql-tests/results/csv-functions.sql.out:
##
@@ -21,7 +21,12 @@ select from_csv('1', 1)
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-The expression '1' is not a valid schema string.; line 1 pos 7
+{
+  "errorClass" : "LEGACY",
+  "messageParameters" : {
+"message" : "The expression '1' is not a valid schema string.; line 1 pos 
7"

Review Comment:
   SPARK-41179



##
sql/core/src/test/resources/sql-tests/results/postgreSQL/join.sql.out:
##
@@ -546,7 +546,12 @@ SELECT '' AS `xxx`, i, k, t
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-Reference 'i' is ambiguous, could be: spark_catalog.default.j1_tbl.i, 
spark_catalog.default.j2_tbl.i.; line 1 pos 20
+{
+  "errorClass" : "LEGACY",
+  "messageParameters" : {
+"message" : "Reference 'i' is ambiguous, could be: 
spark_catalog.default.j1_tbl.i, spark_catalog.default.j2_tbl.i.; line 1 pos 20"

Review Comment:
   SPARK-41172



##
sql/core/src/test/resources/sql-tests/results/postgreSQL/select_implicit.sql.out:
##
@@ -453,7 +463,12 @@ SELECT count(b) FROM test_missing_target x, 
test_missing_target y
 struct<>
 -- !query output