[GitHub] [spark] MaxGekk commented on pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
MaxGekk commented on PR #37725: URL: https://github.com/apache/spark/pull/37725#issuecomment-1338028956 All issues have been fixed. At the moment, all sql tests (in *.sql files) raise exception with error classes. I would propose to merge this change to detect exceptions that are not ported on error classes yet. @cloud-fan Are you ok with that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
MaxGekk commented on PR #37725: URL: https://github.com/apache/spark/pull/37725#issuecomment-1337553614 > @MaxGekk Have all the issues mentioned in this pr been solved? Let me rebase it on the recent master and regenerate golden files, then we will see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
MaxGekk commented on PR #37725: URL: https://github.com/apache/spark/pull/37725#issuecomment-1318946953 @panbingkun @LuciferYang @itholic @cloud-fan @srielau @anchovYu @entong I changed the mechanism of generating SQL golden files in this PR to detect the exceptions that haven't been ported on error classes. There are still a few exceptions for which I opened the JIRAs: - SPARK-41172 - SPARK-41173 - SPARK-41174 - SPARK-41175 - SPARK-41176 - SPARK-41179 - SPARK-41180 - SPARK-41181 - SPARK-41182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
