[GitHub] [spark] ScrapCodes commented on a change in pull request #27966: [SPARK-31200][k8s] Switch https for debian mirrors, to avoid Mirror sync i…
ScrapCodes commented on a change in pull request #27966: [SPARK-31200][k8s] Switch https for debian mirrors, to avoid Mirror sync i… URL: https://github.com/apache/spark/pull/27966#discussion_r399038061 ## File path: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/sources.list ## @@ -0,0 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# This file is required for switching to https url based mirrors, See SPARK-31200, for more info. +deb https://deb.debian.org/debian buster main Review comment: ahh! gotcha. Tomorrow oracle could be using some other base image. In that case, it might not even be of debian type. Then the fix would be a bit more than this, first check if it is a debian image and is using mirrors with http URLs, and then replace it with the `https` ones. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ScrapCodes commented on a change in pull request #27966: [SPARK-31200][k8s] Switch https for debian mirrors, to avoid Mirror sync i…
ScrapCodes commented on a change in pull request #27966: [SPARK-31200][k8s] Switch https for debian mirrors, to avoid Mirror sync i… URL: https://github.com/apache/spark/pull/27966#discussion_r396935593 ## File path: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/sources.list ## @@ -0,0 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# This file is required for switching to https url based mirrors, See SPARK-31200, for more info. +deb https://deb.debian.org/debian buster main Review comment: Not a dumb question, I should have mentioned it earlier. Yes, this was the one already being used. It is also suggested by https://www.debian.org/mirror/list , when the location is not known or this is the only official mirror with CDN support. >If your system moves around a lot, you may be best served by a "mirror" that is backed by a global CDN. The Debian project maintains deb.debian.org for this purpose and you can use this in your apt sources.list — consult the service's website for details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ScrapCodes commented on a change in pull request #27966: [SPARK-31200][k8s] Switch https for debian mirrors, to avoid Mirror sync i…
ScrapCodes commented on a change in pull request #27966: [SPARK-31200][k8s] Switch https for debian mirrors, to avoid Mirror sync i… URL: https://github.com/apache/spark/pull/27966#discussion_r396935593 ## File path: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/sources.list ## @@ -0,0 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# This file is required for switching to https url based mirrors, See SPARK-31200, for more info. +deb https://deb.debian.org/debian buster main Review comment: Not a dumb question, I should have mentioned it earlier. Yes, this was the one already being used. It is also suggested by https://www.debian.org/mirror/list , when the location is not known. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
