[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2020-02-09 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-583972628 I think, this PR is not required. This is an

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-11-18 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-555359901 @cloud-fan @dongjoon-hyun Can you please check this PR

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-11-12 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-552854864 cc @HyukjinKwon This is an automated message

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-11-11 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-552417053 @srowen @dongjoon-hyun @cloud-fan Kindly check this PR.

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-11-09 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-552095846 cc @srowen @gengliangwang @maropu This is an

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-11-09 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-552095812 @brkyvz @cloud-fan @HyukjinKwon Kindly review this PR.

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-11-06 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-550243673 cc @brkyvz @maropu @cloud-fan @HyukjinKwon @gengliangwang

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-11-04 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-549666004 `$ insert into str ((b, a) as data) values named_struct('b', 4, 'a', 1);` This throws compilation error in

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-11-04 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-549372314 Hive, `1) create table str as(select named_struct('a', 1, 'b', 2) as data);` `2) insert into str values

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-11-04 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-549354235 I think, currently, Spark SQL doesn't support insertion in different column order

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-11-03 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-549223603 Retest this please This is an automated message

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-11-03 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-549141254 cc @maropu This is an automated message from the

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-11-03 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-549117583 Okay. I will update this PR with tests. This is

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-10-30 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-548222697 Similar PR https://github.com/apache/spark/pull/26275 have tried handling similar issue.

[GitHub] [spark] amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name

2019-10-30 Thread GitBox
amanomer commented on issue #26293: [SPARK-29595][SQL] Insertion with named_struct should match by name URL: https://github.com/apache/spark/pull/26293#issuecomment-548219477 cc @maropu This is an automated message from the