[GitHub] [spark] beliefer commented on a diff in pull request #40466: [SPARK-42835][SQL][TESTS] Add test cases for `Column.explain`

2023-03-20 Thread via GitHub 


beliefer commented on code in PR #40466:
URL: https://github.com/apache/spark/pull/40466#discussion_r1142825198


##
sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala:
##
@@ -921,6 +922,132 @@ class ColumnExpressionSuite extends QueryTest with 
SharedSparkSession {
 }
   }
 
+  private def captureStdOut(block: => Unit): String = {
+val capturedOut = new ByteArrayOutputStream()
+Console.withOut(capturedOut)(block)
+capturedOut.toString()
+  }
+
+  test("explain") {

Review Comment:
   It is hears better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] beliefer commented on a diff in pull request #40466: [SPARK-42835][SQL][TESTS] Add test cases for `Column.explain`

2023-03-19 Thread via GitHub 


beliefer commented on code in PR #40466:
URL: https://github.com/apache/spark/pull/40466#discussion_r1141536788


##
sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala:
##
@@ -921,6 +922,132 @@ class ColumnExpressionSuite extends QueryTest with 
SharedSparkSession {
 }
   }
 
+  private def captureStdOut(block: => Unit): String = {
+val capturedOut = new ByteArrayOutputStream()
+Console.withOut(capturedOut)(block)
+capturedOut.toString()
+  }
+
+  test("explain") {

Review Comment:
   > Hm, I wouldn't add a bunch of tests though. `expr.sql` isn't actually 
strictly providing the compatibility in its string representation, and this 
test case potentially fails often.
   
   In fact, explain not only reactor `expr.sql`, and `expr.toString` too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org