[GitHub] [spark] beliefer commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-08-25 Thread GitBox


beliefer commented on pull request #28685:
URL: https://github.com/apache/spark/pull/28685#issuecomment-679946677


   > do we have tests to make sure only unbounded frame is supported?
   
   OK



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] beliefer commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-08-25 Thread GitBox


beliefer commented on pull request #28685:
URL: https://github.com/apache/spark/pull/28685#issuecomment-679845065


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] beliefer commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-06-30 Thread GitBox


beliefer commented on pull request #28685:
URL: https://github.com/apache/spark/pull/28685#issuecomment-651601992


   @hvanhovell I have checked PostgreSQL, Vertica, Oracle, Redshift, Presto, 
Teradata, NTH_VALUE is always used as a window function, not as an aggregate 
function.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] beliefer commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-06-28 Thread GitBox


beliefer commented on pull request #28685:
URL: https://github.com/apache/spark/pull/28685#issuecomment-650723511


   retest this please.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org