cloud-fan commented on a change in pull request #26744:
[SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite
URL: https://github.com/apache/spark/pull/26744#discussion_r353050619
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -423,7 +423,7 @@ class DynamicPartitionPruningSuite
"""
|SELECT * FROM fact_sk f
|JOIN dim_store s
- |ON f.date_id = s.store_id
+ |ON f.store_id = s.store_id
Review comment:
Why does this change match the description "no predicate on the dimension
table"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
