cloud-fan commented on a change in pull request #27927: [SPARK-31081][UI][SQL]
Make display of stageId/stageAttemptId/taskId of sql metrics toggleable
URL: https://github.com/apache/spark/pull/27927#discussion_r398591519
##########
File path:
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js
##########
@@ -70,6 +71,10 @@ function setupTooltipForSparkPlanNode(nodeId) {
})
}
+// labelSeparator should be a non-graphical character in order not to affect
the width of boxes.
+var labelSeparator = "\x01";
+var stageAndTaskMetricsPattern = "^(.*)(\\(stage.*attempt.*task[^)]*\\))(.*)$";
Review comment:
Not related to this PR, but a minor comment: now we display task info like
`stage 1 (attempt 2): task 3`. A more standard (and simpler) way to refer to a
stage is `stage 1.2: task 3`.
@sarutak can you help fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
