[GitHub] [spark] cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-14 Thread GitBox
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in 
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-521299935
 
 
   LGTM, merging to master!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-14 Thread GitBox
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in 
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-521200205
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-14 Thread GitBox
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in 
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-521119576
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-13 Thread GitBox
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in 
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-520816943
 
 
   LGTM except https://github.com/apache/spark/pull/25115#discussion_r313371566


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-13 Thread GitBox
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in 
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-520814794
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-06 Thread GitBox
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in 
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-518698777
 
 
   LGTM except two comments


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-06 Thread GitBox
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in 
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-518695136
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-07-25 Thread GitBox
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in 
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-514939370
 
 
   I vote for `SupportsDelete` with a simple method `deleteWhere`. We can have 
the builder API later when we support the row-level delete and MERGE.
   
   There is a similar PR opened a long time ago: 
https://github.com/apache/spark/pull/21308 . Maybe we can borrow the 
doc/comments from it? cc @xianyinxin 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-07-11 Thread GitBox
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in 
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-510488904
 
 
   @xianyinxin thanks for working on it.
   
   A few general questions:
   1. do we need individual interfaces for UPDATE/DELETE/... or a single 
interface?
   2. Is the builder pattern applicable here? To me it's an overkill to simple 
stuff like DELETE. We may need it for MERGE in the future.
   
   also cc @brkyvz @jose-torres 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-07-11 Thread GitBox
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in 
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-510476616
 
 
   ok to test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org