[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available

2019-08-15 Thread GitBox
dongjoon-hyun commented on a change in pull request #25460: 
[SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not 
available
URL: https://github.com/apache/spark/pull/25460#discussion_r314407842
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFsRelation.scala
 ##
 @@ -72,7 +72,8 @@ case class HadoopFsRelation(
 val compressionFactor = sqlContext.conf.fileCompressionFactor
 val defaultSize = (location.sizeInBytes * compressionFactor).toLong
 location match {
-  case cfi: CatalogFileIndex if 
sparkSession.sessionState.conf.fallBackToHdfsForStatsEnabled =>
+  case cfi: CatalogFileIndex if 
sparkSession.sessionState.conf.fallBackToHdfsForStatsEnabled &&
+defaultSize == sqlContext.conf.defaultSizeInBytes =>
 
 Review comment:
   Ya. I know. Officially, we need two more spaces. This is not covered by 
`dev/scalastyle`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available

2019-08-15 Thread GitBox
dongjoon-hyun commented on a change in pull request #25460: 
[SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not 
available
URL: https://github.com/apache/spark/pull/25460#discussion_r314386382
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFsRelation.scala
 ##
 @@ -72,7 +72,8 @@ case class HadoopFsRelation(
 val compressionFactor = sqlContext.conf.fileCompressionFactor
 val defaultSize = (location.sizeInBytes * compressionFactor).toLong
 location match {
-  case cfi: CatalogFileIndex if 
sparkSession.sessionState.conf.fallBackToHdfsForStatsEnabled =>
+  case cfi: CatalogFileIndex if 
sparkSession.sessionState.conf.fallBackToHdfsForStatsEnabled &&
+defaultSize == sqlContext.conf.defaultSizeInBytes =>
 
 Review comment:
   indentation?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org