[GitHub] [spark] dtenedor commented on a diff in pull request #40496: [SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files

2023-03-21 Thread via GitHub
dtenedor commented on code in PR #40496: URL: https://github.com/apache/spark/pull/40496#discussion_r1144040124 ## sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestHelper.scala: ## @@ -59,10 +61,39 @@ trait SQLQueryTestHelper extends Logging { */ protected def

[GitHub] [spark] dtenedor commented on a diff in pull request #40496: [SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files

2023-03-21 Thread via GitHub
dtenedor commented on code in PR #40496: URL: https://github.com/apache/spark/pull/40496#discussion_r1144023834 ## sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestHelper.scala: ## @@ -59,10 +61,39 @@ trait SQLQueryTestHelper extends Logging { */ protected def

[GitHub] [spark] dtenedor commented on a diff in pull request #40496: [SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files

2023-03-21 Thread via GitHub
dtenedor commented on code in PR #40496: URL: https://github.com/apache/spark/pull/40496#discussion_r1144021973 ## sql/core/src/test/resources/sql-tests/analyzer-results/ansi/cast.sql.out: ## @@ -0,0 +1,881 @@ +-- Automatically generated by SQLQueryTestSuite +-- !query +SELECT

[GitHub] [spark] dtenedor commented on a diff in pull request #40496: [SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files

2023-03-20 Thread via GitHub
dtenedor commented on code in PR #40496: URL: https://github.com/apache/spark/pull/40496#discussion_r1142891754 ## sql/core/src/test/resources/sql-tests/analyzer-results/ansi/cast.sql.out: ## @@ -0,0 +1,881 @@ +-- Automatically generated by SQLQueryTestSuite +-- !query +SELECT