[GitHub] [spark] dtenedor commented on pull request #40496: [SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files

[via GitHub]

dtenedor commented on PR #40496:
URL: https://github.com/apache/spark/pull/40496#issuecomment-1483703189

   Looks like @LuciferYang fixed it with 
https://github.com/apache/spark/pull/40552. Thanks so much for the fix!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dtenedor commented on pull request #40496: [SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files

[via GitHub]

dtenedor commented on PR #40496:
URL: https://github.com/apache/spark/pull/40496#issuecomment-1483263177

   @HyukjinKwon I ran the test locally and it passes. Maybe it is fixed at head 
now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dtenedor commented on pull request #40496: [SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files

[via GitHub]

dtenedor commented on PR #40496:
URL: https://github.com/apache/spark/pull/40496#issuecomment-1483097427

   Sure, I can take a look.
   
   On Fri, Mar 24, 2023 at 3:12 AM Hyukjin Kwon ***@***.***>
   wrote:
   
   > I think ANSI test fails after this PR:
   >
   > [info] - timestampNTZ/datetime-special.sql_analyzer_test *** FAILED *** 
(31 milliseconds)
   > [info]   timestampNTZ/datetime-special.sql_analyzer_test
   > [info]   Expected "...date(99, 3, 18, [false) AS make_date(99, 3, 
18)#x, make_date(-1, 1, 28, fals]e) AS make_date(-1, ...", but got 
"...date(99, 3, 18, [true) AS make_date(99, 3, 18)#x, make_date(-1, 1, 
28, tru]e) AS make_date(-1, ..." Result did not match for query #1
   > [info]   select make_date(99, 3, 18), make_date(-1, 1, 28) 
(SQLQueryTestSuite.scala:777)
   > [info]   org.scalatest.exceptions.TestFailedException:
   > [info]   at 
org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
   > [info]   at 
org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
   > [info]   at 
org.scalatest.funsuite.AnyFunSuite.newAssertionFailedException(AnyFunSuite.scala:1564)
   > [info]   at org.scalatest.Assertions.assertResult(Assertions.scala:847)
   > [info]   at org.scalatest.Assertions.assertResult$(Assertions.scala:842)
   > [info]   at 
org.scalatest.funsuite.AnyFunSuite.assertResult(AnyFunSuite.scala:1564)
   > [info]   at 
org.apache.spark.sql.SQLQueryTestSuite.$anonfun$readGoldenFileAndCompareResults$3(SQLQueryTestSuite.scala:777)
   > [info]   at 
scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62)
   >
   > https://github.com/apache/spark/actions/runs/4496107425/jobs/7910457741
   >
   > @dtenedor  mind taking a look please? cc
   > @gengliangwang 
   >
   > —
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   
   
   -- 
   Please write anonymous feedback for Daniel at any time (form
   

   ).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dtenedor commented on pull request #40496: [SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files

[via GitHub]

dtenedor commented on PR #40496:
URL: https://github.com/apache/spark/pull/40496#issuecomment-1478835534

   @HyukjinKwon the tests are passing now, this is ready to merge if you are 
ready :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org