[GitHub] [spark] sandeep-katta edited a comment on pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

[GitBox]

sandeep-katta edited a comment on pull request #28600:
URL: https://github.com/apache/spark/pull/28600#issuecomment-632630597


   this is because I changed the acceptedType to Long and Decimal
   
   
   `  
       checkEvaluation(IntegralDivide(Literal(1.toByte), Literal(2.toByte)), 0L)
       checkEvaluation(IntegralDivide(Literal(1.toShort), Literal(2.toShort)), 
0L)
       checkEvaluation(IntegralDivide(Literal(1), Literal(2)), 0L)
       checkEvaluation(IntegralDivide(Literal(1.toLong), Literal(2.toLong)), 0L)
       checkEvaluation(IntegralDivide(positiveShortLit, negativeShortLit), 0L)
       checkEvaluation(IntegralDivide(positiveIntLit, negativeIntLit), 0L)
       checkEvaluation(IntegralDivide(positiveLongLit, negativeLongLit), 0L)
    `
   
   from the test case shall I remove checkEvaluation for byte,short and int ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org