[GitHub] [spark] simonvanderveldt commented on pull request #38518: [SPARK-33349][K8S] Reset the executor pods watcher when we receive a version changed from k8s

2023-06-30 Thread via GitHub


simonvanderveldt commented on PR #38518:
URL: https://github.com/apache/spark/pull/38518#issuecomment-1615031055

   Please stop using these useless stale bots. Issues and PRs should be closed 
when they are fixed/merged, the passing of time doesn't magically fix anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] simonvanderveldt commented on pull request #38518: [SPARK-33349][K8S] Reset the executor pods watcher when we receive a version changed from k8s

2023-03-21 Thread via GitHub


simonvanderveldt commented on PR #38518:
URL: https://github.com/apache/spark/pull/38518#issuecomment-1478291017

   > To be safe, could you revisie this PR by adding a new internal 
configuration like KUBERNETES_EXECUTOR_ENABLE_API_WATCHER and use it with the 
following?
   
   Not sure this makes sense. AFAIK the current behavior is a bug, so it should 
just be fixed.
   If there's uncertainty about the implementation of this fix then IMHO this 
uncertainty should be addressed.
   For reference, the patch as it was before the config option was added is 
working fine for us, we run about 800 Spark apps a day.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org