[GitHub] [spark] skambha commented on pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-05-29 Thread GitBox
skambha commented on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-636102552 retest this please There are no test failures at that link. Triggering a retest. This is an

[GitHub] [spark] skambha commented on pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-05-28 Thread GitBox
skambha commented on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-635730700 I wanted to summarize where we are at. The changes up to this point took care of whole stage enabled, disabled and ansi enabled/disabled scenarios etc consistently. But based

[GitHub] [spark] skambha commented on pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-05-22 Thread GitBox
skambha commented on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-632935982 Hi @cloud-fan, I have posted some comments on the https://github.com/skambha/spark/pull/1 This is an

[GitHub] [spark] skambha commented on pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-05-21 Thread GitBox
skambha commented on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-632420083 sure @cloud-fan. I will take a look and add comments there. This is an automated message from the Apache Git