[GitHub] [spark] zhengruifeng commented on a diff in pull request #38915: [SPARK-41382][CONNECT][PYTHON] Implement `product` function

2022-12-06 Thread GitBox
zhengruifeng commented on code in PR #38915: URL: https://github.com/apache/spark/pull/38915#discussion_r1040759564 ## connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -552,6 +554,27 @@ class SparkConnectPlanner(session:

[GitHub] [spark] zhengruifeng commented on a diff in pull request #38915: [SPARK-41382][CONNECT][PYTHON] Implement `product` function

2022-12-05 Thread GitBox
zhengruifeng commented on code in PR #38915: URL: https://github.com/apache/spark/pull/38915#discussion_r1040331473 ## connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -539,6 +539,15 @@ class SparkConnectPlanner(session:

[GitHub] [spark] zhengruifeng commented on a diff in pull request #38915: [SPARK-41382][CONNECT][PYTHON] Implement `product` function

2022-12-05 Thread GitBox
zhengruifeng commented on code in PR #38915: URL: https://github.com/apache/spark/pull/38915#discussion_r1040330791 ## connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -539,6 +539,15 @@ class SparkConnectPlanner(session:

[GitHub] [spark] zhengruifeng commented on a diff in pull request #38915: [SPARK-41382][CONNECT][PYTHON] Implement `product` function

2022-12-05 Thread GitBox
zhengruifeng commented on code in PR #38915: URL: https://github.com/apache/spark/pull/38915#discussion_r1039400753 ## connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -539,6 +539,15 @@ class SparkConnectPlanner(session: