zsxwing commented on issue #26076: [SPARK-29419][SQL] Fix Encoder thread-safety bug in createDataset(Seq) URL: https://github.com/apache/spark/pull/26076#issuecomment-540191322 > the caller-supplied `Encoder` is used in multiple threads I would say this is a user error. But I agree that it's pretty easy to overlook. IMO, I made such mistake when I first used `Encoder`. But if we would like to fix all these problems, all public APIs accepting `Encoder` will need the copy. I did some research about this and found some noticeable performance regression in our internal benchmark. That's why I finally just submitted https://github.com/apache/spark/pull/25209 to make users easy to copy an `Encoder` instead.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
