Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12951
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12951
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12951
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/12951
Should we process with this PR or should we close this? @kayousterhout
@njwhite
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user njwhite commented on the issue:
https://github.com/apache/spark/pull/12951
Actually, @kayousterhout - I'm not entirely sure what you expect for the
semantics of maxShares in general. Maybe a worked example would help: if I have
a pool X with 5 running tasks from Taskset A
Github user njwhite commented on the issue:
https://github.com/apache/spark/pull/12951
@kayousterhout minShares is a configuration parameter for the fair
scheduler algorithm only - what would the semantics of a maxShares setting for
the FIFO algorithm be?
---
If your project is set
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12951
@njwhite do you have time to work on this and implement maxShares? If not,
can you close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12951
@njwhite sorry to let this idle for so long. I just read through the
comments here and on the
[JIRA](https://issues.apache.org/jira/browse/SPARK-15176) and it looks like the
consensus on
Github user njwhite commented on the issue:
https://github.com/apache/spark/pull/12951
ping?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user njwhite commented on the issue:
https://github.com/apache/spark/pull/12951
Hi @kayousterhout - I've renamed all references to `maxRunningTasks` and
updated the Markdown documentation in the repo. Is this OK? Thanks -
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12951
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61724/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12951
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12951
**[Test build #61724 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61724/consoleFull)**
for PR 12951 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12951
**[Test build #61724 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61724/consoleFull)**
for PR 12951 at commit
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12951
Also, once naming is settled on, this PR should include a documentation
update to this page: https://spark.apache.org/docs/latest/job-scheduling.html
to describe this.
---
If your project
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12951
The naming on this PR is somewhat confusing, because it looks like
maxShares is supposed to return the maximum number of *remaining* tasks that
can be run, rather than the maximum number of
Github user njwhite commented on the issue:
https://github.com/apache/spark/pull/12951
@squito is this OK?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12951
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12951
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60036/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12951
**[Test build #60036 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60036/consoleFull)**
for PR 12951 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12951
**[Test build #60036 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60036/consoleFull)**
for PR 12951 at commit
Github user njwhite commented on the issue:
https://github.com/apache/spark/pull/12951
@squito thanks - I've expanded the `Scheduler respects maxRunningTasks
setting of its pool` test to cover the cases you mention (and a couple of
others).
---
If your project is set up for it, you
22 matches
Mail list logo