[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-09-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14399 Thank you!!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-09-27 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/14399 Sorry for the late review! LGTM, merging to master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14399 **[Test build #65912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65912/consoleFull)** for PR 14399 at commit

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14399 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14399 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65912/ Test PASSed. ---

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14399 **[Test build #65912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65912/consoleFull)** for PR 14399 at commit

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-09-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14399 Hi @liancheng , I'd appreciate if you could take a look please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-09-08 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14399 Gentle ping @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14399 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63031/ Test PASSed. ---

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14399 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-07-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14399 **[Test build #63031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63031/consoleFull)** for PR 14399 at commit

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-07-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14399 Please let me cc @srowen here as well because it is anyway about building. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-07-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14399 **[Test build #63031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63031/consoleFull)** for PR 14399 at commit

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-07-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14399 @holdenk Yes, the some tests in `ParquetSchemaSuite`. If I remember correctly this, they were, ``` Backwards-compatibility: LIST with nullable element type - 2

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-07-29 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14399 This looks good - I might add a comment about why we are using this approach instead of listOfElements in the code so that whoever comes along next understands why we couldn't use it. Also

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14399 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62998/ Test PASSed. ---

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14399 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-07-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14399 **[Test build #62998 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62998/consoleFull)** for PR 14399 at commit

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-07-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14399 **[Test build #62998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62998/consoleFull)** for PR 14399 at commit

[GitHub] spark issue #14399: [SPARK-16777][SQL] Do not use deprecated listType API in...

2016-07-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14399 cc @holdenk and @liancheng Thanks @holdenk, I was stupid and indeed, the alternative of `listType` is not necessarily `listOfElements` but we can actually work around. --- If your