[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67393/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15072 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15072 **[Test build #67393 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67393/consoleFull)** for PR 15072 at commit [`1298e79`](https://github.com/apache/spark/commit/1298e79fc4c731c24ee42d6d6e4fcd674ec2ff21). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15072 I definitely will tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15072 @HyukjinKwon I cannot cherry-pick this into 2.0. Can you open a PR against 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15072 Merging to master and 2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67392/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15072 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15072 **[Test build #67392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67392/consoleFull)** for PR 15072 at commit [`8bcddc8`](https://github.com/apache/spark/commit/8bcddc8c62fe1299e09e0d2e27ffd907d9571ff5). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15072 (@hvanhovell Thank you for reviewing closly) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15072 LGTM - pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15072 **[Test build #67393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67393/consoleFull)** for PR 15072 at commit [`1298e79`](https://github.com/apache/spark/commit/1298e79fc4c731c24ee42d6d6e4fcd674ec2ff21). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15072 **[Test build #67392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67392/consoleFull)** for PR 15072 at commit [`8bcddc8`](https://github.com/apache/spark/commit/8bcddc8c62fe1299e09e0d2e27ffd907d9571ff5). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15072 @hvanhovell Oh, that looks cleaner and nicer. I will try. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15072
@HyukjinKwon can we move this into a set specific method within Dataset
itself, for example:
```scala
/** A convenient function to wrap a set based logical plan and produce a
Dataset. */
@inline private def withSetPlan[U : Encoder](logicalPlan: => LogicalPlan):
Dataset[U] = {
if (classTag.runtimeClass == classOf[Row]) {
// Set operators widen types (change the schema), so we cannot reuse
the row encoder.
Dataset.ofRows(sparkSession, logicalPlan).asInstanceOf[Dataset[U]]
} else {
Dataset(sparkSession, logicalPlan)
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15072 @liancheng @hvanhovell @davies @cloud-fan Would there be other things maybe I should take care of ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66382/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15072 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15072 **[Test build #66382 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66382/consoleFull)** for PR 15072 at commit [`e27fe51`](https://github.com/apache/spark/commit/e27fe5187818e34ed6b8279327f5dab90b663ec7). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15072 I don't have a better idea either, so this LGTM cc @liancheng do you have any ideas? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15072 **[Test build #66382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66382/consoleFull)** for PR 15072 at commit [`e27fe51`](https://github.com/apache/spark/commit/e27fe5187818e34ed6b8279327f5dab90b663ec7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15072 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65770/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15072 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15072 **[Test build #65770 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65770/consoleFull)** for PR 15072 at commit [`e27fe51`](https://github.com/apache/spark/commit/e27fe5187818e34ed6b8279327f5dab90b663ec7). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15072 **[Test build #65770 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65770/consoleFull)** for PR 15072 at commit [`e27fe51`](https://github.com/apache/spark/commit/e27fe5187818e34ed6b8279327f5dab90b663ec7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user davies commented on the issue: https://github.com/apache/spark/pull/15072 @cloud-fan Could you review this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15072 Hi @hvanhovell, What do you think about this? Would this one be like the one we might merge if we can't find any better way until the next release? or it seems too hacky? I am being hesitated whether I should close this or not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15072 Yeap. BTW, thats because `show()` calls `toDF` internally (as you already know). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15072 Nvm - I need to call `collect()` instead of `show()` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15072 @HyukjinKwon I cannot reproduce the bug using the example you give in the description. I can however reproduce it if I use the example in the JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
