Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16098
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69619/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69619 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69619/consoleFull)**
for PR 16098 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69619 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69619/consoleFull)**
for PR 16098 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69614/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69614 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69614/consoleFull)**
for PR 16098 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69606/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69606 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69606/consoleFull)**
for PR 16098 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69606 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69606/consoleFull)**
for PR 16098 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
It seems the failed test is not related and passed in my local.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69576/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69577/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69577 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69577/consoleFull)**
for PR 16098 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69576 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69576/consoleFull)**
for PR 16098 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69575/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69575 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69575/consoleFull)**
for PR 16098 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69570/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69570 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69570/consoleFull)**
for PR 16098 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69577 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69577/consoleFull)**
for PR 16098 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
Build started: [CORE] `org.apache.spark.JavaAPISuite`
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69576 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69576/consoleFull)**
for PR 16098 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
Build started: [CORE] `org.apache.spark.JavaAPISuite`
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
@srowen and @mridulm Would this be acceptable maybe?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69575 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69575/consoleFull)**
for PR 16098 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
I see. Let me please just revert the change back to
https://github.com/apache/spark/pull/16098/commits/66ff918847a57b3ce4b5abbdf56498e3b871bbf0.
It seems `TaskContextImpl.markTaskFailed(...)`
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
Oh wait, the test seems related with this. Sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69570 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69570/consoleFull)**
for PR 16098 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69568/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69568 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69568/consoleFull)**
for PR 16098 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
Build started: [CORE] `org.apache.spark.JavaAPISuite`
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69568 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69568/consoleFull)**
for PR 16098 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
Thank you both sincerely. Let me fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16098
@srowen This is where try-with-resources is really useful in java.
Util.tryWithSafeFinallyAndFailureCallbacks is an attempt at doing that in
scala with mixed results.
I agree, the
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16098
That looks like a bug in ParquetRecordWriter (the contract of close() is
unambiguous) ... but then, I guess there is no point in fighting against buggy
code : we have to integrate with a lot of
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
Would this make sense if we leave them just as a safe guard maybe?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
I just manually tested this via `ParquetRecordWriter` and it seems throws
an exception as below:
```
java.lang.NullPointerException
at
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16098
Ah, @marmbrus thanks for pointing that out. I see close should be
idempotent by design but I am worried if it is guaranteed that they actually
are. I mean.. for example, `ParquetRecordWriter`'s
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69474/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69474 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69474/consoleFull)**
for PR 16098 at commit
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16098
close is idempotent - simply close it before
'committer.commitTask(taskContext)' and you should be done. The second close in
finally will become no-op in case of successful commit, and will handle
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69475/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16098
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16098
**[Test build #69475 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69475/consoleFull)**
for PR 16098 at commit
56 matches
Mail list logo
